From: "Masayuki Ohtake" Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Fri, 17 Sep 2010 08:55:54 +0900 Message-ID: <000401cb55fa$b6709e90$66f8800a@maildom.okisemi.com> References: <4C8E1773.9090000@dsn.okisemi.com> <4C8E3FDE.2000002@pengutronix.de> <002601cb557c$69292180$66f8800a@maildom.okisemi.com> <4C91DF20.7040807@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Samuel Ortiz , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Marc Kleine-Budde , Tomoya MORINAGA , meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, "David S. Miller" , Christian Pellegrin , qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: "Wolfgang Grandegger" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Hi Wolfgang Grandegger According to your policy, we will remove filter processing so that all packets can be received. Thanks, Ohtake(OKISemi) ----- Original Message ----- From: "Wolfgang Grandegger" To: "Masayuki Ohtake" Cc: "Marc Kleine-Budde" ; ; "Tomoya MORINAGA" ; ; ; ; ; ; ; ; ; "Samuel Ortiz" ; "Barry Song" <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>; "Christian Pellegrin" ; "Wolfram Sang" ; "David S. Miller" Sent: Thursday, September 16, 2010 6:10 PM Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35 > On 09/16/2010 10:51 AM, Masayuki Ohtake wrote: > > Hi Marc, > > > >> - Please remove rx-filter handling from the driver completely, simply > >> receive every can frame > > > > This rx-filter function is for Topcliff's CAN HW function. > > This function is important. > > Could you tell us the reason why should we remove filter function ? > > We do not (yet) support the filtering capability of the CAN controller > hardware. Therefore please configure the hardware filter to accept *any* > CAN message like all other drivers do, e.g.: > > http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249 > > Wolfgang. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >