Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:54807 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758709Ab3D3ByG (ORCPT ); Mon, 29 Apr 2013 21:54:06 -0400 From: Jingoo Han To: 'Guenter Roeck' Cc: 'Andrew Morton' , linux-kernel@vger.kernel.org, 'Wim Van Sebroeck' , linux-watchdog@vger.kernel.org, Jingoo Han References: <000901ce44bc$38dcfbf0$aa96f3d0$@samsung.com> <20130429164425.GJ23799@roeck-us.net> In-reply-to: <20130429164425.GJ23799@roeck-us.net> Subject: Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one() Date: Tue, 30 Apr 2013 10:54:03 +0900 Message-id: <000401ce4545$979de350$c6d9a9f0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote: > On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: > > Use devm_gpio_request_one() to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han > > This patch also addresses the missing gpio_free in the probe error path > (if the call to misc_register() fails). When devm_gpio_request_one() is used, there is no need to call devm_gpio_free(). It is because, these resource managed functions such as devm_gpio_request_one() allow the driver core to automatically clean up any allocation, when probe function fails. > > Reviewed-by: Guenter Roeck Thank you for your reviewing. Best regards, Jingoo Han > > > --- > > drivers/watchdog/mtx-1_wdt.c | 3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c > > index 14dab6f..b434111 100644 > > --- a/drivers/watchdog/mtx-1_wdt.c > > +++ b/drivers/watchdog/mtx-1_wdt.c > > @@ -209,7 +209,7 @@ static int mtx1_wdt_probe(struct platform_device *pdev) > > int ret; > > > > mtx1_wdt_device.gpio = pdev->resource[0].start; > > - ret = gpio_request_one(mtx1_wdt_device.gpio, > > + ret = devm_gpio_request_one(&pdev->dev, mtx1_wdt_device.gpio, > > GPIOF_OUT_INIT_HIGH, "mtx1-wdt"); > > if (ret < 0) { > > dev_err(&pdev->dev, "failed to request gpio"); > > @@ -241,7 +241,6 @@ static int mtx1_wdt_remove(struct platform_device *pdev) > > wait_for_completion(&mtx1_wdt_device.stop); > > } > > > > - gpio_free(mtx1_wdt_device.gpio); > > misc_deregister(&mtx1_wdt_misc); > > return 0; > > } > > -- > > 1.7.2.5 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >