Received: from eggs.gnu.org ([2001:4830:134:3::10]:42881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAxZv-00055g-SY for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:16:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAxZq-0000qC-PR for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:15:59 -0500 Received: from mail.ispras.ru ([83.149.199.45]:34304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAxZq-0000q1-IE for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:15:54 -0500 From: "Pavel Dovgaluk" References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120111.3504.51955.stgit@PASHA-ISP> <54B3BA70.3080408@redhat.com> In-Reply-To: Date: Tue, 13 Jan 2015 12:15:54 +0300 Message-ID: <000401d02f11$88a9c000$99fd4000$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Pavel Dovgaluk' , 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Pavel Dovgaluk [mailto:Pavel.Dovgaluk@ispras.ru] > > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > > On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > > > + default: > > > + case QEMU_CLOCK_VIRTUAL: > > > + if ((replay_mode !=3D REPLAY_MODE_NONE && = !runstate_is_running()) > > > + || !replay_checkpoint(run_all ? 2 : 3)) { > > > + return false; > > > + } > > > + break; > > > > Please document the meaning of the numbers by making an enum. >=20 > The numbers have no meaning. They just have to be distinct in = different places. >=20 > > Why do you have to distinguish run_all? >=20 > It seems to be early versions artifact. I'll remove it. Sorry, missed one thing. run_all is used to distinguish timers processed in AIO by calling of = timerlistgroup_run_timers function and in main loop by calling qemu_clock_run_all_timers. We need to distinguish that to secure the sequence of the events. It makes sense when we use checkpointing while recording the execution. Pavel Dovgalyuk