Message-ID: <00064007-a592-772b-0cbd-20335323bd40@...1227...> Date: Wed, 26 Jan 2022 17:29:50 +0100 MIME-Version: 1.0 Content-Language: en-GB References: <20220126151128.5078-1-a@...2181...> From: Arne Schwabe In-Reply-To: <20220126151128.5078-1-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH] crypto.c: remove (dead) OpenSSL specific code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net Cc: David Sommerseth Am 26.01.22 um 16:11 schrieb Antonio Quartulli: > Originally we wanted to move this OpenSSL specific code to its own > backend and use a proper abstraction in the crypto.c code. > > However, tests have revealed that OpenVPN will never try to print a > cipher that is not supported by FIPS (assuming FIPS is enabled), because > along the chain of calls we already call cipher_get() which returns NULL > for FIPS-disabled ciphers. > > For this reason, we can just remove any FIPS specific code from > print_cipher() and be done with it. > Acked-By: Arne Schwabe