Received: from eggs.gnu.org ([2001:4830:134:3::10]:37784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL3i7-0001iX-Fm for qemu-devel@nongnu.org; Tue, 10 Feb 2015 00:50:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL3i4-00022n-9R for qemu-devel@nongnu.org; Tue, 10 Feb 2015 00:50:11 -0500 Received: from mail.ispras.ru ([83.149.199.45]:51518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL3i4-00022Y-20 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 00:50:08 -0500 From: "Pavel Dovgaluk" References: <20150209075530.4252.76551.stgit@PASHA-ISP> <54D86A13.4070506@weilnetz.de> <001b01d0443f$798174e0$6c845ea0$@Dovgaluk@ispras.ru> <54D90EE6.50402@weilnetz.de> In-Reply-To: <54D90EE6.50402@weilnetz.de> Date: Tue, 10 Feb 2015 08:50:06 +0300 Message-ID: <000901d044f5$6d265790$477306b0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Stefan Weil' , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, zealot351@gmail.com, maria.klimushenkova@ispras.ru > From: Stefan Weil [mailto:sw@weilnetz.de] > Am 09.02.2015 um 09:07 schrieb Pavel Dovgaluk: > >> From: Stefan Weil [mailto:sw@weilnetz.de] > >> Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > >>> On w64, setjmp is implemented by _setjmp which needs a second parameter. > >>> This parameter should be NULL to allow using longjump from generated code. > >>> This patch replaces all usages of setjmp.h with new header files which > >>> replaces setjmp with _setjmp function on win64 platform. > >>> > >>> Signed-off-by: Pavel Dovgalyuk > >> Please have a look at include/sysemu/os-win32.h. I think that your patch > >> is not needed because the current code already uses _setjmp. > > Right, but some of the files (e.g. include/qom/cpu.h) include setjmp.h directly. > > Then we have the following for compiling cpu-exec.c: > > > > cpu-exec.c: > > ... > > os-win32.h > > ... > > setjmp.h > > ... > > > > In this situation cpu-exec will call incorrect setjmp function. > > > > Pavel Dovgalyuk > > > It won't call the wrong setjmp function, at least not in my tests. > cpu-exec.c gets the setjmp declaration from os-win32.h. Without it, QEMU > would be unusable because it would crash very soon during the emulation. > > Do you see problems caused by a wrong setjmp with latest QEMU? If yes: > which build environment do you use (host, compiler, version of MinGW*)? Yes, I've got the problems. To verify the correctness of the call I disassembled cpu-exec.o and found that setjmp is called with second parameter not equal to zero. I'm using Cygwin environment and packages from here: http://win-builds.org/ My host OS is Windows 7x64 and the compiler is x86_64-w64-mingw32-gcc.exe (GCC) 4.8.3 Pavel Dovgalyuk