From: Chao Yu Subject: Re: [PATCH v3] f2fs crypto: allocate buffer for decrypting filename Date: Wed, 16 Sep 2015 18:11:02 +0800 Message-ID: <000901d0f068$1a1bd100$4e537300$@samsung.com> References: <1441936062-69511-1-git-send-email-jaegeuk@kernel.org> <20150911224550.GA73045@jaegeuk-mac02.mot.com> <20150915165215.GA82346@jaegeuk-mac02.mot.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: stable@vger.kernel.org To: 'Jaegeuk Kim' , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Return-path: In-reply-to: <20150915165215.GA82346@jaegeuk-mac02.mot.com> Content-language: zh-cn List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Wednesday, September 16, 2015 12:52 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: stable@vger.kernel.org > Subject: Re: [f2fs-dev] [PATCH v3] f2fs crypto: allocate buffer for decrypting filename > > Change log from v1: > o fix wrong pointer assignment > > Chang log from v2: > o add one more missing call path: f2fs_encrypted_follow_link > > >From 84574dd5c3e8ed9ca9fdfcbd251b354cdbc5ecab Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Thu, 3 Sep 2015 13:38:23 -0700 > Subject: [PATCH 1/3] f2fs crypto: allocate buffer for decrypting filename > > We got dentry pages from high_mem, and its address space directly goes into the > decryption path via f2fs_fname_disk_to_usr. > But, sg_init_one assumes the address is not from high_mem, so we can get this > panic since it doesn't call kmap_high but kunmap_high is triggered at the end. > > kernel BUG at ../../../../../../kernel/mm/highmem.c:290! > Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM > ... > (kunmap_high+0xb0/0xb8) from [] (__kunmap_atomic+0xa0/0xa4) > (__kunmap_atomic+0xa0/0xa4) from [] (blkcipher_walk_done+0x128/0x1ec) > (blkcipher_walk_done+0x128/0x1ec) from [] (crypto_cbc_decrypt+0xc0/0x170) > (crypto_cbc_decrypt+0xc0/0x170) from [] (crypto_cts_decrypt+0xc0/0x114) > (crypto_cts_decrypt+0xc0/0x114) from [] (async_decrypt+0x40/0x48) > (async_decrypt+0x40/0x48) from [] (f2fs_fname_disk_to_usr+0x124/0x304) > (f2fs_fname_disk_to_usr+0x124/0x304) from [] (f2fs_fill_dentries+0xac/0x188) > (f2fs_fill_dentries+0xac/0x188) from [] (f2fs_readdir+0x1f0/0x300) > (f2fs_readdir+0x1f0/0x300) from [] (vfs_readdir+0x90/0xb4) > (vfs_readdir+0x90/0xb4) from [] (SyS_getdents64+0x64/0xcc) > (SyS_getdents64+0x64/0xcc) from [] (ret_fast_syscall+0x0/0x30) > > Cc: > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/dir.c | 14 +++++++++++--- > fs/f2fs/namei.c | 8 +++++++- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > index 8f15fc1..cce512c 100644 > --- a/fs/f2fs/dir.c > +++ b/fs/f2fs/dir.c > @@ -773,6 +773,7 @@ bool f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr > *d, > unsigned int bit_pos; > struct f2fs_dir_entry *de = NULL; > struct f2fs_str de_name = FSTR_INIT(NULL, 0); > + char *name = NULL; > > bit_pos = ((unsigned long)ctx->pos % d->max); > > @@ -788,8 +789,10 @@ bool f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr > *d, > d_type = DT_UNKNOWN; > > /* encrypted case */ > - de_name.name = d->filename[bit_pos]; > de_name.len = le16_to_cpu(de->name_len); > + name = kmalloc(de_name.len, GFP_NOFS); How do you think of handling the failure of kmalloc with GFP_NOFS? > + memcpy(name, d->filename[bit_pos], de_name.len); If current inode is not encrypted, our kmalloc & memcpy will be overhead, How about changing our codes to avoid that? Thanks, ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140