Received: from eggs.gnu.org ([2001:4830:134:3::10]:58651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeeBk-0007LA-0a for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeeBg-00014J-Qh for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:09:59 -0400 Received: from mail.ispras.ru ([83.149.199.45]:50133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeeBg-00011u-Ju for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:09:56 -0400 From: "Pavel Dovgaluk" References: <20150917162322.8676.29314.stgit@PASHA-ISP.def.inno> <20150917162427.8676.36558.stgit@PASHA-ISP.def.inno> <5601545E.9090000@redhat.com> In-Reply-To: <5601545E.9090000@redhat.com> Date: Wed, 23 Sep 2015 10:09:53 +0300 Message-ID: <000901d0f5ce$d9750f60$8c5f2e20$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, hines@cert.org, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > > + if ((now < last || now > (last + get_max_clock_jump())) > > + && replay_mode == REPLAY_MODE_NONE) { > > notifier_list_notify(&clock->reset_notifiers, &now); > > This seems wrong. You will have different timers in the record and the > replay if you do not invoke e.g. rtc_notify_clock_reset. That will "work" - record and replay will be equivalent. But they will differ from normal mode. It'll better remove it from the patch. Pavel Dovgalyuk