From: Chao Yu Subject: Re: [PATCH] f2fs: move all the bio initialization into __bio_alloc Date: Thu, 19 Dec 2013 09:23:18 +0800 Message-ID: <000a01cefc59$0a9b4580$1fd1d080$@samsung.com> References: <52B17905.7040708@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: 'fsdevel' , 'linux-kernel' , 'f2fs' To: 'Gu Zheng' , 'Kim' Return-path: In-reply-to: <52B17905.7040708@cn.fujitsu.com> Content-language: zh-cn List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org Hi Gu, > -----Original Message----- > From: Gu Zheng [mailto:guz.fnst@cn.fujitsu.com] > Sent: Wednesday, December 18, 2013 6:29 PM > To: Kim > Cc: fsdevel; linux-kernel; f2fs > Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc > > Move all the bio initialization into __bio_alloc, and some minor cleanups are > also added. Looks more neat! > @@ -178,17 +179,16 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page, > block_t blk_addr, struct f2fs_io_info *fio) > { > enum page_type btype = PAGE_TYPE_OF_BIO(fio->type); > - struct block_device *bdev = sbi->sb->s_bdev; > struct f2fs_bio_info *io; > - int bio_blocks; > + int rw = is_read_io(fio->rw); Maybe it's more neat to use 'is_read' to instead of 'rw'. Thanks ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk