Received: from eggs.gnu.org ([2001:4830:134:3::10]:35372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeeO1-00024w-Rw for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:22:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeeNy-00076v-Pv for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:22:41 -0400 Received: from mail.ispras.ru ([83.149.199.45]:50393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeeNy-00076K-JZ for qemu-devel@nongnu.org; Wed, 23 Sep 2015 03:22:38 -0400 From: "Pavel Dovgaluk" References: <20150917162322.8676.29314.stgit@PASHA-ISP.def.inno> <20150917162439.8676.38290.stgit@PASHA-ISP.def.inno> <56015479.8020403@redhat.com> In-Reply-To: <56015479.8020403@redhat.com> Date: Wed, 23 Sep 2015 10:22:38 +0300 Message-ID: <000a01d0f5d0$a05b8720$e1129560$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, hines@cert.org, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > > #endif > > > > + /* CPU thread can infinitely wait for event after > > + missing the warp */ > > + qemu_clock_warp(QEMU_CLOCK_VIRTUAL); > > qemu_clock_run_all_timers(); > > It is still not clear to me why the call in timerlist_rearm is not > sufficient. Can you explain this (again probably)? Sometimes tcg thread halts in qemu_tcg_wait_io_event function, waiting for any external event. Virtual clock does not run, because warp is not called. warp call in main_loop_wait proceeds virtual clock and allows tcg thread to run further. Pavel Dovgalyuk