Received: from eggs.gnu.org ([2001:4830:134:3::10]:54375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdzZ-0008HW-C4 for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:21:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAdzV-0006kW-55 for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:21:09 -0500 Received: from mail.ispras.ru ([83.149.199.45]:48492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdzU-0006kB-Tx for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:21:05 -0500 From: "Pavel Dovgaluk" References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112115958.3504.62352.stgit@PASHA-ISP> <54B3BBC4.2080804@redhat.com> In-Reply-To: <54B3BBC4.2080804@redhat.com> Date: Mon, 12 Jan 2015 15:21:04 +0300 Message-ID: <001101d02e62$3c20ce40$b4626ac0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 12/01/2015 12:59, Pavel Dovgalyuk wrote: > > +## > > +# ReplaySubmode: > > +# > > +# Submode of the replay subsystem. > > +# > > +# @unknown: used for modes different from play. > > +# > > +# @normal: normal replay mode. > > +# > > +# Since: 2.3 > > +## > > +{ 'enum': 'ReplaySubmode', > > + 'data': [ 'unknown', 'normal' ] } > > What is a submode? Can you just check if replay_file is NULL? Submode is not very useful for these core patches. More submodes will be introduces in reverse debugging patches. Pavel Dovgalyuk