Received: from eggs.gnu.org ([2001:4830:134:3::10]:33746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAeUO-00041B-6f for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:53:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAeUL-0000vp-0v for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:53:00 -0500 Received: from mail.ispras.ru ([83.149.199.45]:49208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAeUK-0000ut-Pw for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:52:56 -0500 From: "Pavel Dovgaluk" References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120009.3504.5362.stgit@PASHA-ISP> <54B3C2CC.40407@redhat.com> In-Reply-To: <54B3C2CC.40407@redhat.com> Date: Mon, 12 Jan 2015 15:52:56 +0300 Message-ID: <001501d02e66$afe07890$0fa169b0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v7 04/21] replay: internal functions for replay log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini > On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > > + > > +volatile unsigned int replay_data_kind = -1; > > +volatile unsigned int replay_has_unread_data; > > + > > Why does this have to be volatile? I think 'volatile' is an artifact from the earlier version. Could be removed then. Pavel Dovgalyuk