From: lookkas@gmail.com
Subject: Re: KSM overcommit test review - 1st pass (issue183068)
Date: Mon, 28 Dec 2009 04:08:43 +0000
Message-ID: <001636c92b40ae96db047bc20fea@google.com>
Reply-To: lookkas@gmail.com, autotest@test.kernel.org, kvm@vger.kernel.org,
	jzupka@redhat.com, reply@codereview.appspotmail.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, reply@codereview.appspotmail.com,
	kvm@vger.kernel.org
To: lookkas@gmail.com
Return-path: <autotest-bounces@test.kernel.org>
List-Unsubscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=unsubscribe>
List-Archive: <http://test.kernel.org/pipermail/autotest>
List-Post: <mailto:autotest@test.kernel.org>
List-Help: <mailto:autotest-request@test.kernel.org?subject=help>
List-Subscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=subscribe>
Sender: autotest-bounces@test.kernel.org
Errors-To: autotest-bounces@test.kernel.org
List-Id: kvm.vger.kernel.org

Hi Jiri, thank you very much for your work! I have comments to make
regarding to coding style as a first pass review. While reading them,
please keep in mind autotest's coding standards:

http://autotest.kernel.org/browser/trunk/CODING_STYLE

Also, I have noticed lots of trailing spaces on lines. I recommend that
every time you are done working with the code, you use the very useful
script utils/reindent.py (see top level autotest directory) that will
remove all trailing spaces on your code. While I wrote this first pass
review, I have applied it on the resultant files.


http://codereview.appspot.com/183068