Received: from eggs.gnu.org ([2001:4830:134:3::10]:46331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIGKw-0000f5-P0 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:42:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIGKt-0007JO-HA for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:42:42 -0500 Received: from mail.ispras.ru ([83.149.199.45]:46411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIGKt-0007Ih-9X for qemu-devel@nongnu.org; Mon, 02 Feb 2015 07:42:39 -0500 From: "Pavel Dovgaluk" References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <20150122085215.5276.8878.stgit@PASHA-ISP.def.inno> <54C9FE31.4090404@redhat.com> <001801d03ee3$c8cb7660$5a626320$@Dovgaluk@ispras.ru> <54CF6FA9.7090600@redhat.com> In-Reply-To: <54CF6FA9.7090600@redhat.com> Date: Mon, 2 Feb 2015 15:42:38 +0300 Message-ID: <001901d03ee5$ba5d1640$2f1742c0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>> > > cpu->exception_index = EXCP_INTERRUPT; > >>> > > next_tb = 0; > >>> > > + qemu_notify_event(); > >> > > >> > Why is this needed? > > It is needed to wake up iothread in replay mode. > > Otherwise it waits for additional time and replay becomes too slow. > > What event (something from a timerlist?) is ready, that has not been > notified to the iothread yet? qemu_notify_event() should never be > needed in common case. It's probably missing somewhere else. I think in this case there are no events at all - just reading timers values that were made while recording. We have to replay these reads by waking iothread. Pavel Dovgalyuk