From: Simon Goldschmidt Date: Thu, 3 Oct 2019 21:18:12 +0200 Subject: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing In-Reply-To: <8e51203e-630f-a99f-0c89-35ca8d0676cd@denx.de> References: <20191002225554.11397-1-marex@denx.de> <20191002225554.11397-2-marex@denx.de> <9b362a09-d690-ed62-be76-f2e7bbaad2c4@denx.de> <4e0e5224-0dde-b1b3-b6ae-af9a3b7a6f2f@denx.de> <8e51203e-630f-a99f-0c89-35ca8d0676cd@denx.de> Message-ID: <001a9f17-7528-81fa-b112-7927c674ecba@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 03.10.2019 um 21:12 schrieb Marek Vasut: > [...] >>>>>> Are you aware that DM WDT is enabled in SPL by default for gen5 now? I >>>>> get >>>>>> a message that WDT is not found. I haven't sent a patch to fix that >>> yet, >>>>>> since the message is the only thing that happens, works normally >>>>> otherwise. >>>>>> >>>>>> But if you're working on that, you might check side effects of that >>>>> setting >>>>>> (which is new for this release). >>>>> >>>>> That doesn't sound right, the SoCFPGA core code uses HW_WATCHDOG in some >>>>> places as Ley pointed out, so if DM WDT is enabled in SPL, that code in >>>>> HW_WATCHDOG ifdefs isn't used. And I think that will trigger some weird >>>>> problems. So in the end, enabling DM watchdog in SoCFPGA SPL right now >>>>> is a bug ? >>>>> >>>> >>>> Hmm, it probably is. I'm not using a watchdog right now, so I couldn't >>>> really tell... It'll be a week or so until I'll find the time for u-boot >>>> again :-( >>> >>> We probably should fix that before the release though. >>> >> >> If it's a problem, then yes, we should. Let me see if I can squeeze it in >> tomorrow... > > Thanks > > I almost suspect it's one of my WDT DM conversion patches which caused this. Hehe, a fast blame on github shows me you're right :-) The problem is that SPL_WATCHDOG_SUPPORT (which is selected by ARCH_SOCFPGA) implies SPL_WDT if !HW_WATCHDOG. Now for my board, HW_WATCHDOG is obviously disabled. I'd have to check the mainline gen5 boards though... I'll try to check socfpga_socrates tomorrow and check the other boards by comparing the defconfigs. Regards, Simon