Received: from eggs.gnu.org ([2001:4830:134:3::10]:49149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKjNi-0008Di-90 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 03:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKjNd-0005WK-BN for qemu-devel@nongnu.org; Mon, 09 Feb 2015 03:07:46 -0500 Received: from mail.ispras.ru ([83.149.199.45]:34651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKjNd-0005WE-4r for qemu-devel@nongnu.org; Mon, 09 Feb 2015 03:07:41 -0500 From: "Pavel Dovgaluk" References: <20150209075530.4252.76551.stgit@PASHA-ISP> <54D86A13.4070506@weilnetz.de> In-Reply-To: <54D86A13.4070506@weilnetz.de> Date: Mon, 9 Feb 2015 11:07:40 +0300 Message-ID: <001b01d0443f$798174e0$6c845ea0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Stefan Weil' , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, zealot351@gmail.com, maria.klimushenkova@ispras.ru > From: Stefan Weil [mailto:sw@weilnetz.de] > Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > > On w64, setjmp is implemented by _setjmp which needs a second parameter. > > This parameter should be NULL to allow using longjump from generated code. > > This patch replaces all usages of setjmp.h with new header files which > > replaces setjmp with _setjmp function on win64 platform. > > > > Signed-off-by: Pavel Dovgalyuk > > Please have a look at include/sysemu/os-win32.h. I think that your patch > is not needed because the current code already uses _setjmp. Right, but some of the files (e.g. include/qom/cpu.h) include setjmp.h directly. Then we have the following for compiling cpu-exec.c: cpu-exec.c: ... os-win32.h ... setjmp.h ... In this situation cpu-exec will call incorrect setjmp function. Pavel Dovgalyuk