Received: from eggs.gnu.org ([2001:4830:134:3::10]:38848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKnFX-0000Ol-Uz for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:15:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKnFS-0002al-Ud for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:15:35 -0500 Received: from mail.ispras.ru ([83.149.199.45]:38575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKnFS-0002aA-GT for qemu-devel@nongnu.org; Mon, 09 Feb 2015 07:15:30 -0500 From: "Pavel Dovgaluk" References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <20150122085323.5276.64995.stgit@PASHA-ISP.def.inno> <54CB62E5.3000807@redhat.com> In-Reply-To: <54CB62E5.3000807@redhat.com> Date: Mon, 9 Feb 2015 15:15:28 +0300 Message-ID: <001c01d04462$17a41f20$46ec5d60$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces command line options for enabling recording or replaying > > virtual machine behavior. "-record" option starts recording of the execution > > and saves it into the log, specified with "fname" parameter. "-replay" option > > is intended for replaying previously saved log. > > > > Signed-off-by: Pavel Dovgalyuk > > break; > > case QEMU_OPTION_snapshot: > > snapshot = 1; > > @@ -3105,6 +3114,7 @@ int main(int argc, char **argv, char **envp) > > #endif > > case QEMU_OPTION_bt: > > add_device_config(DEV_BT, optarg); > > + not_compatible_replay_param++; > > Could it be enough to add a migration blocker? Record/replay core does not use migration subsystem. That is why it should check the hardware by itself. > > > break; > > case QEMU_OPTION_audio_help: > > AUD_help (); > > @@ -3244,6 +3254,7 @@ int main(int argc, char **argv, char **envp) > > if (!opts) { > > exit(1); > > } > > + not_compatible_replay_param++; > > Why not compatible? Replay for audio adapter will be added in latter patches. Trying to record/replay machine with audio using current set of patches will break the replay. Pavel Dovgalyuk