Received: from eggs.gnu.org ([2001:4830:134:3::10]:37365)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from
) id 1YvqG8-0000TH-GD
for qemu-devel@nongnu.org; Fri, 22 May 2015 12:57:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1YvqG5-0007Wf-6v
for qemu-devel@nongnu.org; Fri, 22 May 2015 12:57:20 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:20983)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1YvqG5-0007WS-1b
for qemu-devel@nongnu.org; Fri, 22 May 2015 12:57:17 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
by mailout2.w1.samsung.com
(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
2014)) with ESMTP id <0NOR009R0GFE7C80@mailout2.w1.samsung.com> for
qemu-devel@nongnu.org; Fri, 22 May 2015 17:57:14 +0100 (BST)
From: Pavel Fedin
References:
<555F487C.8020207@linaro.org>
In-reply-to: <555F487C.8020207@linaro.org>
Date: Fri, 22 May 2015 19:57:13 +0300
Message-id: <001f01d094b0$5a1c3f60$0e54be20$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH RFC 4/4] Initial implementation of vGICv3.
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: 'Eric Auger' , qemu-devel@nongnu.org
Cc: 'Shlomo Pongratz' , 'Ashok Kumar'
Hi!
> Looks GICv3 common class currently miss this security_extn field +
> parent_fiq so it does not compile without changes. Or did I miss something?
Just throw this if(...) away. It's my fault. Actually i have rebased Shlomo's patches on
yesterday's master, and during this i added parent_fiq[] to GICv3, because without filling
these in the thing stopped working due to recent GICv2 code changes. I needed to fix the
problem quickly, so i copied initializing parent_fiq together with security_extn field
from v2 code. But, this makes no sense because security_extn is never initialized, it is
not even assigned property name. So just remove this small fragment, it's not needed now.
I have fixed this in my working tree 2 hours ago. parent_fiq is declared as:
--- cut ---
qemu_irq parent_fiq[GICV3_NCPU];
--- cut ---
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia