Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF19C3A5A0 for ; Mon, 20 Apr 2020 08:58:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BE1B20A8B for ; Mon, 20 Apr 2020 08:58:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qjx8Z0Ed" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE1B20A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQSGG-0000SI-IO; Mon, 20 Apr 2020 08:58:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQSGF-0000SD-EK for xen-devel@lists.xenproject.org; Mon, 20 Apr 2020 08:58:39 +0000 X-Inumbo-ID: 1fc90c5c-82e5-11ea-b4f4-bc764e2007e4 Received: from mail-ed1-x533.google.com (unknown [2a00:1450:4864:20::533]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1fc90c5c-82e5-11ea-b4f4-bc764e2007e4; Mon, 20 Apr 2020 08:58:38 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id w2so6739798edx.4 for ; Mon, 20 Apr 2020 01:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=l12LqyTH4YgL3udx+mMMxH3mer6k55ySqu3cyDYdhec=; b=Qjx8Z0Ed/kKdXep5rDdvFhr5KVGQog4BiWtrplRP6hSSskyzCXPWh0sTr+5Pl3MOKW ot1j5t9vUjdC0xTr8FtSt3a6gMHp2ZK/lgqqQrWc3Tl8GaQ5jnu4b2zKzyGNLQ+zo+Si gELZtGQTjhMNVtGgM8fHjEtyd2YvM7QfwVBVm9JFk4aenWBS5GwmmoSHSAzXnGwnYk9V e+7sWwg19gPqG43omTfeUJG0GSTPj1tkb/ATOvzk3I40JxqseDUZ8F8I5WZpP07IYKAw 8ujUjxBCyM9jH1e08GsCk6PBoTzW/YI9MNngOH7sOudKp5IhcLccjUg3RvQAu/dj0jLf mYKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=l12LqyTH4YgL3udx+mMMxH3mer6k55ySqu3cyDYdhec=; b=XeZvYIbe3gE6E5YpUwTJUILEaqu1An/uOR3z4FInJmFSl0ad7stfrAmHMudc1PALD5 aJCEo0Otkle6EG2lB/ISr7lWy4F7aTW8eesOvNcHJIen/bgTqwrI2SMrZjc1F9QvrQNM ntvC6hS7sGoi5Val9Dv2OKchXiNOdepCPxRTmp6cef+ORengWHHRZI7Set/di1gfxTeZ nEaJT0/fJLfD0MZ9RdG++RgnWGWmbhsR52AXm/K+iJK4nLWSf0FlWRYjm+dbk4c9XoSl bYvAWlw+XPLB9JM9PhfpiY8jjXqn5RuFQRe6jr25j5VFi2NE/Bf/obGMNTUzLIkwbtft Un2A== X-Gm-Message-State: AGi0PubFpsVHi680wGUUCVHzUQ2G3hdPAL9LzbYmKGpx2SgQ1zKFSfMV WplED/jq0smf6U4BFEr9p44= X-Google-Smtp-Source: APiQypIKPCo2plSHpjjzSAMNGT9aA4e3L7shMprjSVglVHH/8jSrvmcyN8rO+29d1JFDuoXpyr19cQ== X-Received: by 2002:a05:6402:310b:: with SMTP id dc11mr12798473edb.143.1587373117743; Mon, 20 Apr 2020 01:58:37 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.186]) by smtp.gmail.com with ESMTPSA id dm15sm21184edb.84.2020.04.20.01.58.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 01:58:37 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Markus Armbruster'" , References: <20200420083236.19309-1-armbru@redhat.com> <20200420083236.19309-10-armbru@redhat.com> In-Reply-To: <20200420083236.19309-10-armbru@redhat.com> Subject: RE: [PATCH 09/11] xen/pt: Fix flawed conversion to realize() Date: Mon, 20 Apr 2020 09:58:35 +0100 Message-ID: <002201d616f1$e1057910$a3106b30$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIW6PbL/TFzdKd45gQwHtYhr73cEQJR6tGlp+2CVEA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Anthony Perard' , xen-devel@lists.xenproject.org, 'Stefano Stabellini' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Markus Armbruster > Sent: 20 April 2020 09:33 > To: qemu-devel@nongnu.org > Cc: Stefano Stabellini ; Anthony Perard ; Paul > Durrant ; xen-devel@lists.xenproject.org > Subject: [PATCH 09/11] xen/pt: Fix flawed conversion to realize() > > The conversion of xen_pt_initfn() to xen_pt_realize() blindly replaced > XEN_PT_ERR() by error_setg(). Several error conditions that did not > fail xen_pt_initfn() now fail xen_pt_realize(). Unsurprisingly, the > cleanup on these errors looks highly suspicious. > > Revert the inappropriate replacements. > > Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6 > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Signed-off-by: Markus Armbruster Reviewed-by: Paul Durrant