Received: from eggs.gnu.org ([2001:4830:134:3::10]:46871)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from
) id 1ZxAeZ-0007qZ-JL
for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:28:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1ZxAeW-000609-At
for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:28:19 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:25827)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1ZxAeW-0005za-4i
for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:28:16 -0500
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
by mailout4.w1.samsung.com
(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
2014)) with ESMTP id <0NXQ00I49YAZPB80@mailout4.w1.samsung.com> for
qemu-devel@nongnu.org; Fri, 13 Nov 2015 09:28:11 +0000 (GMT)
From: Pavel Fedin
Date: Fri, 13 Nov 2015 12:28:10 +0300
Message-id: <002301d11df5$9d440a10$d7cc1e30$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support
eventfds
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: qemu-devel@nongnu.org
Cc: "'Michael S. Tsirkin'"
If you happen to have a stock kernel of old version, like 3.x, and you
attempt to enable vhost by setting vhost=on, qemu aborts with error:
kvm_mem_ioeventfd_add: error adding ioeventfd: Function not implemented
This patch adds capability check, so that vhost gets disabled instead. A
warning is displayed, explaining the reason.
This problem can be observed with libvirt, which checks for /dev/vhost-net
availability and just inserts "vhost=on" automatically in this case.
Signed-off-by: Pavel Fedin
---
hw/virtio/vhost.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 1794f0d..3121e19 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -24,6 +24,7 @@
#include "hw/virtio/virtio-bus.h"
#include "hw/virtio/virtio-access.h"
#include "migration/migration.h"
+#include "sysemu/kvm.h"
static struct vhost_log *vhost_log;
static struct vhost_log *vhost_log_shm;
@@ -1083,6 +1084,11 @@ int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
r = -ENOSYS;
goto fail;
}
+ if (!kvm_eventfds_enabled()) {
+ error_report("KVM does not support MMIO eventfds");
+ r = -ENOSYS;
+ goto fail;
+ }
for (i = 0; i < hdev->nvqs; ++i) {
r = k->set_host_notifier(qbus->parent, hdev->vq_index + i, true);
--
1.9.5.msysgit.0