From: Jingoo Han Subject: [PATCH] mmc: sdhci-pci: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:23:30 +0900 Message-ID: <002601ceb7fb$83531ea0$89f95be0$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:36432 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611Ab3IWBXe (ORCPT ); Sun, 22 Sep 2013 21:23:34 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00GPG164EPC0@mailout2.samsung.com> for linux-mmc@vger.kernel.org; Mon, 23 Sep 2013 10:23:33 +0900 (KST) Content-language: ko Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org, 'Adrian Hunter' , 'Jingoo Han' The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c index d7d6bc8..f0d20f0 100644 --- a/drivers/mmc/host/sdhci-pci.c +++ b/drivers/mmc/host/sdhci-pci.c @@ -1533,7 +1533,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev, return 0; free: - pci_set_drvdata(pdev, NULL); kfree(chip); err: @@ -1555,7 +1554,6 @@ static void sdhci_pci_remove(struct pci_dev *pdev) for (i = 0; i < chip->num_slots; i++) sdhci_pci_remove_slot(chip->slots[i]); - pci_set_drvdata(pdev, NULL); kfree(chip); } -- 1.7.10.4