From: Pavel Fedin <p.fedin@samsung.com>
References: <1444739866-14798-1-git-send-email-berrange@redhat.com>
	<1444739866-14798-7-git-send-email-berrange@redhat.com>
	<563B9A7C.4010000@suse.de> <20151106093128.GA30803@redhat.com>
In-reply-to: <20151106093128.GA30803@redhat.com>
Date: Fri, 06 Nov 2015 12:37:43 +0300
Message-id: <003001d11876$ca2c8d60$5e85a820$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list
 with GHashTable
To: "'Daniel P. Berrange'" <berrange@redhat.com>, =?UTF-8?Q?'Andreas_F=C3=A4rber'?= <afaerber@suse.de>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org, 'Markus Armbruster' <armbru@redhat.com>

 Hello!

> > > -    QTAILQ_FOREACH(prop, &obj->parent->properties, node) {
> > > +    g_hash_table_iter_init(&iter, obj->parent->properties);
> > > +    while (g_hash_table_iter_next(&iter, NULL, (gpointer *)&prop)) {
> >
> > Is this cast needed?
> 
> Probably not, as any pointer should coerce to void * without an
> explicit cast, unless it had a 'const' involved.

 But after '&' it becomes "**", not just "*", and this implicit conversion
rule doesn't apply any more. "void **" and "something **" are always considered
different.	

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia