From: "Masayuki Ohtake" Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Tue, 14 Sep 2010 09:46:36 +0900 Message-ID: <003a01cb53a6$4ca724d0$66f8800a@maildom.okisemi.com> References: <4C61EDE5.4030505@dsn.okisemi.com> <4C629FE5.6000204@pengutronix.de> <005f01cb533e$5c21d530$66f8800a@maildom.okisemi.com> <4C8E1918.5000007@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Morinaga , meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Wolfgang Grandegger To: "Marc Kleine-Budde" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Hi Marc, >>> - implement NAPI >> Since Topcliff CAN HW register has only single rx buffer, >> I think NAPI is unnecessary. > Doesn't matter. Please try to implement it. Our CAN driver must pull received data from CAN-HW rx buffer as fast as it can so that the received data is not over-written by next received data. In case of implemented with NAPI, since NAPI has time-lagging after receiving first packet, probability of over-written(discarded) buffer is to be high. Thus, for our CAN HW, we should NOT implement with NAPI but normal "netif_rx". Thanks, Ohtake(OKISemi) ----- Original Message ----- From: "Marc Kleine-Budde" To: "Masayuki Ohtake" Cc: ; ; ; ; ; ; "Morinaga" ; ; ; "Wolfgang Grandegger" Sent: Monday, September 13, 2010 9:29 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 > On 09/13/2010 02:07 PM, Masayuki Ohtake wrote: > >> - Try to send patches directly with git send-email > > In our network environment, we can't use send-email. > > that's bad...talk to your IT department :) > > >> - don't use global variables > > I have modified so that our patch doesn't use global variable except module parameter. > > > >> - don't use that "int handle", e.g.: > > I have deleted. > > > > > >> - get rid of the intermediate struct pch_can_msg: > >> Your data path is: > >> struct can_frame -> struct pch_can_msg -> registers > >> write from struct can_frame into registers directly > > Since Topcliff CAN HW register assign is different from struct can_frame, > > I think intermediate structure is necessary. > > I don't see any reason for this. No other driver has an intermediate > struct. Look at the other drivers. > > >> - what's the purpose of "p_can_os->can_callback", call the function > >> directly from the interrupt handler > > I have deleted > > > >> - implement NAPI > > Since Topcliff CAN HW register has only single rx buffer, > > I think NAPI is unnecessary. > > Doesn't matter. Please try to implement it. > > >> - get rid of "1<< BIT_SHIFT_SIX" and friend, > >> use "1<< 6" or "BIT(6)" if you like defines > > I have modified. > > > >> - use defines to set bits in struct can_frame can_id > > I have modified. > > > > I will resubmit modified our CAN patch soon. > > > > Thanks, Ohtake(OKISemi) > > cheers, Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | >