Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CEDC47254 for ; Tue, 5 May 2020 14:00:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5357E20757 for ; Tue, 5 May 2020 14:00:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Quia9v/x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5357E20757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVy76-00007b-0d; Tue, 05 May 2020 14:00:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVy75-00007V-KP for xen-devel@lists.xenproject.org; Tue, 05 May 2020 13:59:59 +0000 X-Inumbo-ID: b4ca7800-8ed8-11ea-b9cf-bc764e2007e4 Received: from mail-ed1-x532.google.com (unknown [2a00:1450:4864:20::532]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b4ca7800-8ed8-11ea-b9cf-bc764e2007e4; Tue, 05 May 2020 13:59:59 +0000 (UTC) Received: by mail-ed1-x532.google.com with SMTP id w2so1858624edx.4 for ; Tue, 05 May 2020 06:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=O9OCBMkBxpYV7nwYvW253+iHNM16Xw+0gCVniK4rZ0A=; b=Quia9v/xRYgVnTDwV1BgYeICL+6UIoPhizH6hPPF4DkNcTtvHJl5Ty9UDZWF1Wj0AF FS3KgmAq6KlzYeXdYQ3OA++1Q4I0seBrL8agnF3UoSJLLSKmOeC9DQqvrhlT51K/e1v3 xgF6OTVucZjrirHv5xQwRe0P3H9l5KoUo+hkDyXcUw1NGQ9dQeGxOR/N8raXLcTN0s5g wPBq8vTmzTMQayESPKqeEdcHb8eiqjxUByqyltjrifpPut7NUtSbThKGFcm/cKMcc+tQ RrGmgDnKGOp8PJc1PEzW2mY7Ht46+7iAqPL4RGQCqPpT46h6N8Zf18TpGw7OoG96GT/c phFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :thread-index:content-language; bh=O9OCBMkBxpYV7nwYvW253+iHNM16Xw+0gCVniK4rZ0A=; b=Dly9hIY12hAjM1B9MrKYrdPcmNJfLHPK4kjY16nuBjabx7fPz0Q0DI7pyN0VILhaKT +e4KkkV07DKso2aJkcmPEyiLOMYm7n38KGqaDiRarkcVuEmKGVHy732HoBGl7mobylSp OAFqx7pecCn93v+TsNRgAhQlhdJ0ney7L/opfaIywyJsGzRmoML0vtQphEJa/pxPG39A UY+4nbAlj8/U0SGjaaFIUgcstnOrmMq0nzZg2hKR/jWXSYdfHJcjQ5LxX68weAdTYjF0 9w4iQhHGCisuxei3HgJRn8/Iq6mXyYMt1IebFbY/rHl2gef2MO161CHDsCPHBIWy3XxE ai6A== X-Gm-Message-State: AGi0PuacaDDE1Z+2DCHw+2UINFjDXJuZ+hi4TiaMTCtfhe8u5R0PboJn tQbtwNhYXilRQvAIzMfkFrQ= X-Google-Smtp-Source: APiQypKMaCbhuhWKhU6qOX1gyF4ylKwmgItCJ0Vgnfw2kOhlHOT2eRuqxGQbmSbMf9zCagFUVC55Eg== X-Received: by 2002:aa7:c0d2:: with SMTP id j18mr2756750edp.283.1588687198204; Tue, 05 May 2020 06:59:58 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.187]) by smtp.gmail.com with ESMTPSA id n7sm280474edt.69.2020.05.05.06.59.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2020 06:59:57 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Markus Armbruster'" , References: <20200505101908.6207-1-armbru@redhat.com> <20200505101908.6207-3-armbru@redhat.com> In-Reply-To: <20200505101908.6207-3-armbru@redhat.com> Subject: RE: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors Date: Tue, 5 May 2020 14:59:56 +0100 Message-ID: <004001d622e5$75fd2d70$61f78850$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQD2kCtjJmTvNkmzRgy8FtMMvttLfQNDV1uLqj6PYxA= Content-Language: en-gb X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Anthony Perard' , xen-devel@lists.xenproject.org, 'Stefano Stabellini' , 'Gerd Hoffmann' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Markus Armbruster > Sent: 05 May 2020 11:19 > To: qemu-devel@nongnu.org > Cc: Stefano Stabellini ; Anthony Perard ; Paul > Durrant ; Gerd Hoffmann ; xen-devel@lists.xenproject.org > Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors > > usbback_portid_add() leaks the error when qdev_device_add() fails. > Fix that. While there, use the error to improve the error message. > > The qemu_opts_from_qdict() similarly leaks on failure. But any > failure there is a programming error. Pass &error_abort. > > Fixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2 > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Cc: Gerd Hoffmann > Cc: xen-devel@lists.xenproject.org > Signed-off-by: Markus Armbruster Acked-by: Paul Durrant