From: Namjae Jeon Subject: RE: [PATCH] xfstests: fsstress: fix incorrect if condition check for collapse range mode Date: Wed, 30 Apr 2014 19:33:14 +0900 Message-ID: <004501cf645f$97d5b6b0$c7812410$@samsung.com> References: <004401cf645c$8f874710$ae95d530$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Cc: 'Dave Chinner' , xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, 'Ashish Sangwan' To: =?iso-8859-2?Q?'Luk=E1=B9_Czerner'?= Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:32698 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757475AbaD3Kd3 (ORCPT ); Wed, 30 Apr 2014 06:33:29 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4U00D31ANFQU80@mailout1.samsung.com> for linux-fsdevel@vger.kernel.org; Wed, 30 Apr 2014 19:33:15 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > On Wed, 30 Apr 2014, Namjae Jeon wrote: > > > Date: Wed, 30 Apr 2014 19:11:32 +0900 > > From: Namjae Jeon > > To: Dave Chinner > > Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, > > Ashish Sangwan > > Subject: [PATCH] xfstests: fsstress: fix incorrect if condition check for > > collapse range mode > > > > There is if condition to be block aligned for off and len of Collapse range. > > But off and len for all fallocate opearion can be aligned by incorrect > > if condition check. > > > > Signed-off-by: Namjae Jeon > > Signed-off-by: Ashish Sangwan > > --- > > ltp/fsstress.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ltp/fsstress.c b/ltp/fsstress.c > > index 29fc250..ff9ed12 100644 > > --- a/ltp/fsstress.c > > +++ b/ltp/fsstress.c > > @@ -2230,7 +2230,7 @@ do_fallocate(int opno, long r, int mode) > > * Collapse range requires off and len to be block aligned, make it > > * more likely to be the case. > > */ > > - if (FALLOC_FL_COLLAPSE_RANGE && (opno % 2)) { > > + if (mode & FALLOC_FL_COLLAPSE_RANGE && (opno % 2)) { > > off = ((off + stb.st_blksize - 1) & ~(stb.st_blksize - 1)); > > len = ((len + stb.st_blksize - 1) & ~(stb.st_blksize - 1)); > > } > > oops :). Thanks for fixing it. Even though it would be better to use > parentheses Hi Lukas. Okay, I will send v2 patch. Thanks for review! > > + if ((mode & FALLOC_FL_COLLAPSE_RANGE) && (opno % 2)) { > > Reviewed-by: Lukas Czerner