From: "cron2 (Code Review)" Date: Thu, 23 Jan 2025 15:22:20 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <005a503db71e8dfa16b758e92c019c9c4e9990ab-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="YqZslSHi58w="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --YqZslSHi58w= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, ordex, plais= thos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/436?usp=3Demail ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 11: (4 comments) Patchset: PS11: A few comments to look at, but at this point I'd say "fix the manpage and s= hip" ;-) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/5e7f4c84_d49c3a9f : PS11, Line 124: open a socket. As discussed on IRC, this is still a bit unclear / a leftover from earlier = versions. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/87b58fcf_5e96bec6 : PS11, Line 2485: if (le->local && !ce->bind_local) I do wonder if we really need to check this for every entry in the local_li= st, or checking it once (`if ( ce->local_list && !ce->bind_local )`) would = be sufficient... but this is not really important. http://gerrit.openvpn.net/c/openvpn/+/436/comment/9744ee88_ecea7af7 : PS11, Line 3780: options_postprocess_mutate_le(o->ce, o->ce.loc= al_list->array[i]); I guess that this is preparations for one of the later patches? For the si= mple case having an extra function 420 lines further up in the code seems m= ore complicated then necessary. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 11 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: its_Giaan Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Thu, 23 Jan 2025 15:22:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --YqZslSHi58w= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, ordex, p= laisthos.

View C= hange

4 comments:

    =
  • Patchset:

    • Patch Set #11:

      A few comments to look at, but at this point I&#= 39;d say "fix the manpage and ship" ;-)

  • File doc/man-sections/link-options.rst:

  • File src/openvp= n/options.c:

    • Patch = Set #11, Line 2485: = if (le->local && !ce->bind_local)

      I do wonder if we really nee= d to check this for every entry in the local_list, or checking it once (`if= ( ce->local_list && !ce->bind_local )`) would be sufficient.= .. but this is not really important.

    • Patch Set #11, Line = 3780: optio= ns_postprocess_mutate_le(o->ce, o->ce.local_list->array[i]);

      I guess tha= t this is preparations for one of the later patches? For the simple case h= aving an extra function 420 lines further up in the code seems more complic= ated then necessary.

To view, visit change 436. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a= dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 11
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: its_Giaan <gianmarco@...1664...= 26...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Thu, 23 Jan 2025 15:22:20= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--YqZslSHi58w=--