Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A721C433E0 for ; Thu, 4 Jun 2020 07:50:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 133D0206DC for ; Thu, 4 Jun 2020 07:50:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y7FVr2ng" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 133D0206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgkeB-0001Bf-MG; Thu, 04 Jun 2020 07:50:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgkeA-0001BY-7T for xen-devel@lists.xenproject.org; Thu, 04 Jun 2020 07:50:42 +0000 X-Inumbo-ID: 164fd9b4-a638-11ea-9947-bc764e2007e4 Received: from mail-ed1-x52d.google.com (unknown [2a00:1450:4864:20::52d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 164fd9b4-a638-11ea-9947-bc764e2007e4; Thu, 04 Jun 2020 07:50:41 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id p18so3884927eds.7 for ; Thu, 04 Jun 2020 00:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=KuNf6C8p5U/pV3cH0HVswaojeUwltwpCkRZOPJXfz5U=; b=Y7FVr2ngIEYiTZl0edDmqaq9hjMiz1SmKQ1oDwyTCFTi/JqtYouQr+coxnkN8/bJ6S UttOnOwPTlxH2RLs+d2qsCPfvHLfCSeGD6GYiWE9/gEssC9KMvVJ9Kce+yvmYUU6c98s +ORackNhRTr35ij070nHuJBJ0Dti4Bn9SII7MP8KrmigtSZf/3DfjzW8LGPb5fGkmb3P Xz32erOHc63npK4zPMbOPqIpu/rEv9RDbWY1KkvrcaYnur0Bo9xMtBEYYjry3E06Rjt4 Zn5Mynf+Zwju4RdzJhq700/wXU+tLJKq65NHFK1y0TlocrEtZPodGYsUBIghWtQ9Sh7u Ihhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=KuNf6C8p5U/pV3cH0HVswaojeUwltwpCkRZOPJXfz5U=; b=W0Jq7IFp2/RUmQtbYgW470D5CnsLcAI3fbJVG6zBHU4oQR2fgmoHsFYDf+pZ4ZwKgy MFRQ8CCiqApo0gzsS2xTqUCXzLNh3A4qbrnvXolIzbx5h2d58izqte6fHhUZN1HZM3CM Hkt+4uPY7G4icA2WpccMQlu76ALiQFx2fVADnGYO5BGY/qDtmrjyu76eJgMQ1UhrN2la m7e6jHEfEhcbwPo3j2flUaDdEE6pBIl73fk91uO6PDn1ml4Afbo+TS89/++OwnDvFsIB lph9glUTXVrc0pOVZCgjP6cL2DXDd68oSDhTvUZkpfofFDB92eB93fo+2InI0r+tUSJu ATdA== X-Gm-Message-State: AOAM531T50lw69f6xwwoIRLqiG2RK8/AlE+4fkYXB9/fvu2GIhJFSjti f2YKNT4R853l3h7HJMgzzPA= X-Google-Smtp-Source: ABdhPJzJ0sjZoihPlAmf98Qw/AKjHh5M3IVSEWx63Kk3T1jB0sk90e4VwRp2MBwMtOHhrUn3IipHUg== X-Received: by 2002:a50:fd01:: with SMTP id i1mr3346973eds.32.1591257040795; Thu, 04 Jun 2020 00:50:40 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.186]) by smtp.gmail.com with ESMTPSA id n6sm1557427edv.24.2020.06.04.00.50.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2020 00:50:40 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Jan Beulich'" , "'Andrew Cooper'" References: <20200603170908.13239-1-andrew.cooper3@citrix.com> <1a158ff8-e11e-432c-236d-ff884602d48a@suse.com> In-Reply-To: <1a158ff8-e11e-432c-236d-ff884602d48a@suse.com> Subject: RE: [PATCH for-4.14] x86/shim: Fix defconfig selection and trim the build further Date: Thu, 4 Jun 2020 08:50:38 +0100 Message-ID: <006501d63a44$d771e0c0$8655a240$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQDiB7eoitU4qCF1PTePgHsB/Nx/GAHHmGl6qqI9QAA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Juergen Gross' , 'Xen-devel' , 'Dario Faggioli' , 'Wei Liu' , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Jan Beulich > Sent: 04 June 2020 07:43 > To: Andrew Cooper > Cc: Xen-devel ; Wei Liu ; = Roger Pau Monn=C3=A9 > ; Juergen Gross ; Paul Durrant = ; Dario Faggioli > > Subject: Re: [PATCH for-4.14] x86/shim: Fix defconfig selection and = trim the build further >=20 > On 03.06.2020 19:09, Andrew Cooper wrote: > > Several options (TBOOT, XENOPROF, Scheduler) depend on EXPERT to be = able to > > deselect/configure. > > > > Enabling EXPERT now causes the request of the Credit1 scheduler to = be honoured > > (rather than giving us Credit2), but take this opportunity to switch = to Null, > > as the previously problematic issues are now believed to be fixed. > > > > Enabling EXPERT also allows XEN_SHSTK to be selected, and we don't = want this > > being built for shim. We also don't want TRACEBUFFER or GDBSX = either. > > > > Take this oppotunity to swap the disable of HVM_FEP for a general = disable of > > HVM (likely to have wider impliciations in the future), and disable = ARGO (will > > necesserily need plumbing work to function in shim). >=20 > Odd. I was quite sure this is the case already; in particular my > own build test of a shim config has this already. >=20 > > Signed-off-by: Andrew Cooper >=20 > Reviewed-by: Jan Beulich Release-acked-by: Paul Durrant >=20 > I have a question though (without implying the patch here needs > adjusting, but rather with a look towards after 4.14): >=20 > > --- a/xen/arch/x86/configs/pvshim_defconfig > > +++ b/xen/arch/x86/configs/pvshim_defconfig > > @@ -5,19 +5,25 @@ CONFIG_PVH_GUEST=3Dy > > CONFIG_PV_SHIM=3Dy > > CONFIG_PV_SHIM_EXCLUSIVE=3Dy > > CONFIG_NR_CPUS=3D32 > > +CONFIG_EXPERT=3Dy > > +CONFIG_SCHED_NULL=3Dy > > # Disable features not used by the PV shim > > +# CONFIG_HVM is not set > > +# CONFIG_XEN_SHSTK is not set > > # CONFIG_HYPFS is not set > > # CONFIG_SHADOW_PAGING is not set > > # CONFIG_BIGMEM is not set > > -# CONFIG_HVM_FEP is not set > > # CONFIG_TBOOT is not set > > # CONFIG_KEXEC is not set > > # CONFIG_XENOPROF is not set > > # CONFIG_XSM is not set > > +# CONFIG_ARGO is not set > > +# CONFIG_SCHED_CREDIT is not set > > # CONFIG_SCHED_CREDIT2 is not set > > # CONFIG_SCHED_RTDS is not set > > # CONFIG_SCHED_ARINC653 is not set > > -# CONFIG_SCHED_NULL is not set > > # CONFIG_LIVEPATCH is not set > > # CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS is not set > > +# CONFIG_TRACEBUFFER is not set > > # CONFIG_DEBUG is not set > > +# CONFIG_GDBSX is not set >=20 > I assume both the "enable" and "disable" sections here are ordered > like they would be in a resulting full .config. But this being two > separate sections, doing so doesn't help e.g. diff-ing. How about > we sort both sections alphabetically (short of other good sorting > criteria, yet better than entirely unsorted)? >=20 > Jan