Received: from eggs.gnu.org ([2001:4830:134:3::10]:39413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJMWY-0003a5-Ke for qemu-devel@nongnu.org; Sun, 26 Jul 2015 10:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJMWP-0007la-5f for qemu-devel@nongnu.org; Sun, 26 Jul 2015 10:03:30 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJMWP-0007lC-0g for qemu-devel@nongnu.org; Sun, 26 Jul 2015 10:03:21 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS3006DQLPGCI40@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Sun, 26 Jul 2015 15:03:16 +0100 (BST) From: Pavel Fedin References: <1694c9da0a9d58f9d84e65665a00657682dc15b5.1437731107.git.p.fedin@samsung.com> In-reply-to: Date: Sun, 26 Jul 2015 17:03:14 +0300 Message-id: <007d01d0c7ab$d1326420$73972c60$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v7 2/6] Implement GIC-500 base class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Peter Maydell' Cc: 'Shlomo Pongratz' , 'Shlomo Pongratz' , 'QEMU Developers' , 'Christoffer Dall' , 'Eric Auger' Hello! > > + > > +typedef struct gicv3_irq_state { > > + /* The enable bits are only banked for per-cpu interrupts. */ > > + uint64_t enabled; > > + uint64_t pending; > > + uint64_t active; > > + uint64_t level; > > + uint64_t group; >=20 > Why are these uint64_t ? I studied the code for a little bit more. These are bitmasks, where bit = represents a CPU. Take a look at gicv3_internal.h, = GIC_SET/CLEAR/TEST_xxx macros. 'cm' stands for 'cpu mask'. This is currently not used by my code, this is mainly for Shlomo's SW = emulation. However, there is some usage in common class initialization = code. And i will fix up all badly understood comments. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia