From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: codec: hdac_hdmi add device_link to card device Date: Fri, 12 Apr 2019 10:02:33 -0500 Message-ID: <007db6e3-2534-93f7-5edf-2bdf11c5c4cf@linux.intel.com> References: <1555036832-2850-1-git-send-email-libin.yang@intel.com> <8c33f4c2-39ce-a620-b540-c933e4157b83@linux.intel.com> <96A12704CE18D347B625EE2D4A099D1952818DDD@SHSMSX103.ccr.corp.intel.com> <96A12704CE18D347B625EE2D4A099D1952819530@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BFD84F80716 for ; Fri, 12 Apr 2019 17:02:36 +0200 (CEST) In-Reply-To: <96A12704CE18D347B625EE2D4A099D1952819530@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: "Yang, Libin" , "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "broonie@kernel.org" List-Id: alsa-devel@alsa-project.org On 4/12/19 9:33 AM, Yang, Libin wrote: >>> >>>>>> + device_link_add(component->card->dev, &hdev->dev, >>>>> DL_FLAG_RPM_ACTIVE | >>>>>> + DL_FLAG_AUTOREMOVE_CONSUMER); >>>>> >>>>> Should device_link_free() be added to hdmi_codec_remove then? >>>> >>>> As Takashi suggested, I add the DL_FLAG_AUTOREMOVE_CONSUMER flag. >>>> This will make sure the link will be freed when machine driver are removed. >>>> And as machine driver depends on the hdac_hdmi module, when >>>> hdmi_codec_remove() is called, the link is freed already. >>> >>> ok, maybe adding a comment would help dummies like me who didn't know >>> about this flag? Thanks! >> >> Thanks for suggestion. I will add the comment. > > After a second thought, is there any possibility that the machine driver does > not depend on the hdac_hdmi module? I checked our current driver, > there is the dependency between machine driver and hdac_hdmi module. I don't get your question. All machine drivers supporting the iDISP link explicitly use a select HDAC_HDMI in the Kconfig and refer to DAIs created/exposed by the hdac_hdmi module. It's possible that the hdac_hdmi codec is probed as a result of the platform driver configuration but the machine driver does not support HDMI. In that case, is there any issue with your solution?