Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89315C2D0E4 for ; Tue, 17 Nov 2020 19:46:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D17520674 for ; Tue, 17 Nov 2020 19:46:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJINZe74" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D17520674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.29255.58565 (Exim 4.92) (envelope-from ) id 1kf6vZ-0000Zo-VB; Tue, 17 Nov 2020 19:46:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 29255.58565; Tue, 17 Nov 2020 19:46:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf6vZ-0000Zh-Rv; Tue, 17 Nov 2020 19:46:09 +0000 Received: by outflank-mailman (input) for mailman id 29255; Tue, 17 Nov 2020 19:46:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf6vZ-0000Zb-7V for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 19:46:09 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7845435a-e6e8-4aaa-a58d-8e7731568280; Tue, 17 Nov 2020 19:46:07 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id m6so7319662wrg.7 for ; Tue, 17 Nov 2020 11:46:07 -0800 (PST) Received: from CBGR90WXYV0 (host109-146-187-185.range109-146.btcentralplus.com. [109.146.187.185]) by smtp.gmail.com with ESMTPSA id q12sm5256327wmc.45.2020.11.17.11.46.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2020 11:46:06 -0800 (PST) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf6vZ-0000Zb-7V for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 19:46:09 +0000 X-Inumbo-ID: 7845435a-e6e8-4aaa-a58d-8e7731568280 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7845435a-e6e8-4aaa-a58d-8e7731568280; Tue, 17 Nov 2020 19:46:07 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id m6so7319662wrg.7 for ; Tue, 17 Nov 2020 11:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=WhbrHOh5eSpBRYHEg/N9n8NuGSwrwc/G6QPCxIY3d7o=; b=GJINZe74AIO3LsMz4NPEuLCLOt64/dNnqvA9/+lV8h+n2ZiLUq3+CClnjJtNjvm+m5 CGpbMCd+cfkhaRg+YFqA5QbTQPfJPuVxpTUsGjDQalpIDfuIXGGYGBuS3arOF7DHCLW7 p6SzGIVkAusKoW78k00lFqtg0i3uupddXKg3tFa4dQ0/uzPd1T409QYZZh//9IVOsxbM dYo1ZS17eV0EqVILT4xMIgybIPAH105+Oh1ANeevC8sz5jy594VzOEwLFiHUtneTo534 yqUSmRqZF8Vi3KDfqAB1hvdXpDe/F9gB7gWc8b+vhmHTGAanmOfQIvaTw2ZaK1usrqi7 wLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=WhbrHOh5eSpBRYHEg/N9n8NuGSwrwc/G6QPCxIY3d7o=; b=lv69SdCg7mCSkIK+/PdpJW0G8fdgPLYn6R0NKa+sqpOrfH3ZvCmLICZzaaVTd7T5ti LQCP/vPxHfwUUJny5s+HrBS5s/MLd3DPusW3QXOzqsl3/EXiXq8R3s8jC52Lsc0RYbVN pMFd1ec5f7unuBPl1lCtUpVyNF0q5d8lRRdRbzsbM8kf7IepEoBCAw9H/DAOYqJaaoWv FXFcDXPElZQRUtZ+8ltzOqNhXT3PbwkVRjSTi5HgfadjAt93AIgzKTnTa4zW+qSKqDGl PgxYrBJ/G2oLcp97JZa5Fq8nyug3xW9W7MWppc2oPVor48IQMEs8oa9km5Lwv+26Q2cI pBPA== X-Gm-Message-State: AOAM533+M89ZrrUG7GwTMmuGBU5DFSjTW/YYRuUVgdDwg1zC1JgMPYnH //+lFvhduoXo/EDv+19AWWI= X-Google-Smtp-Source: ABdhPJxsmC9uOcSOcnMknob71tiENDIwTJyS8x40iGMs+a69olsrp5uWjSEgv0MisZ0dO48QImq7Hg== X-Received: by 2002:adf:f9c6:: with SMTP id w6mr1113204wrr.273.1605642367105; Tue, 17 Nov 2020 11:46:07 -0800 (PST) Received: from CBGR90WXYV0 (host109-146-187-185.range109-146.btcentralplus.com. [109.146.187.185]) by smtp.gmail.com with ESMTPSA id q12sm5256327wmc.45.2020.11.17.11.46.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2020 11:46:06 -0800 (PST) From: Paul Durrant X-Google-Original-From: "Paul Durrant" Reply-To: To: "'Oleksandr Andrushchenko'" , Cc: "'Paul Durrant'" , "'Anthony PERARD'" , "'Christian Lindig'" , "'David Scott'" , "'George Dunlap'" , "'Ian Jackson'" , "'Nick Rosbrook'" , "'Wei Liu'" References: <20201110175147.7067-1-paul@xen.org> In-Reply-To: Subject: RE: [PATCH v2 00/24] xl / libxl: named PCI pass-through devices Date: Tue, 17 Nov 2020 19:46:05 -0000 Message-ID: <009901d6bd1a$4a1b97d0$de52c770$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQHVuwFKgyCNjAECHbA+TpJefiRY1gJP93B7qbw+PMA= > -----Original Message----- > From: Oleksandr Andrushchenko > Sent: 16 November 2020 10:34 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Anthony PERARD = ; Christian Lindig > ; David Scott ; George = Dunlap > ; Ian Jackson ; Nick = Rosbrook ; > Wei Liu > Subject: Re: [PATCH v2 00/24] xl / libxl: named PCI pass-through = devices >=20 > Hi, Paul! >=20 > On 11/10/20 7:51 PM, Paul Durrant wrote: > > From: Paul Durrant > > > > Paul Durrant (24): > > xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X > > libxl: use LIBXL_DEFINE_DEVICE_LIST for pci devices > > libxl: use LIBXL_DEFINE_DEVICE_LIST for nic devices > > libxl: s/detatched/detached in libxl_pci.c > > libxl: remove extraneous arguments to do_pci_remove() in = libxl_pci.c > > libxl: stop using aodev->device_config in = libxl__device_pci_add()... > > libxl: generalise 'driver_path' xenstore access functions in > > libxl_pci.c > > libxl: remove unnecessary check from libxl__device_pci_add() > > libxl: remove get_all_assigned_devices() from libxl_pci.c > > libxl: make sure callers of libxl_device_pci_list() free the list > > after use > > libxl: add libxl_device_pci_assignable_list_free()... > > libxl: use COMPARE_PCI() macro is_pci_in_array()... > > libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore > > libxl: Make sure devices added by pci-attach are reflected in the > > config > > docs/man: extract documentation of PCI_SPEC_STRING from the = xl.cfg > > manpage... > > docs/man: improve documentation of PCI_SPEC_STRING... > > docs/man: fix xl(1) documentation for 'pci' operations > > libxl: introduce 'libxl_pci_bdf' in the idl... > > libxlu: introduce xlu_pci_parse_spec_string() > > libxl: modify > > libxl_device_pci_assignable_add/remove/list/list_free()... > > docs/man: modify xl(1) in preparation for naming of assignable = devices > > xl / libxl: support naming of assignable devices > > docs/man: modify xl-pci-configuration(5) to add 'name' field to > > PCI_SPEC_STRING > > xl / libxl: support 'xl pci-attach/detach' by name > > > > docs/man/xl-pci-configuration.5.pod | 218 ++++++ > > docs/man/xl.1.pod.in | 39 +- > > docs/man/xl.cfg.5.pod.in | 68 +- > > tools/golang/xenlight/helpers.gen.go | 77 +- > > tools/golang/xenlight/types.gen.go | 8 +- > > tools/include/libxl.h | 67 +- > > tools/include/libxlutil.h | 8 +- > > tools/libs/light/libxl_create.c | 6 +- > > tools/libs/light/libxl_dm.c | 18 +- > > tools/libs/light/libxl_internal.h | 53 +- > > tools/libs/light/libxl_nic.c | 19 +- > > tools/libs/light/libxl_pci.c | 1030 = ++++++++++++++------------ > > tools/libs/light/libxl_types.idl | 19 +- > > tools/libs/util/libxlu_pci.c | 379 +++++----- > > tools/ocaml/libs/xl/xenlight_stubs.c | 19 +- > > tools/xl/xl_cmdtable.c | 16 +- > > tools/xl/xl_parse.c | 28 +- > > tools/xl/xl_pci.c | 159 ++-- > > tools/xl/xl_sxp.c | 12 +- > > 19 files changed, 1308 insertions(+), 935 deletions(-) > > create mode 100644 docs/man/xl-pci-configuration.5.pod >=20 > Patches 1-18: >=20 > Reviewed-by: Oleksandr Andrushchenko = >=20 > (I'll probably review more later as time allows). >=20 >=20 > I would like to ask the respective maintainers to look at this series = as, in the light of the >=20 > upcoming changes for ARM PCI passthrough, these changes greatly help = in adapting the >=20 > code for ARM >=20 FWIW, I believe there is still an issue in one of the patches (probably = patch #14) which has caused problems for pass-through of multiple = devices. I will debug that in the next couple of days and post v3. Paul > Thank you, >=20 > Oleksandr >=20 > > --- > > Cc: Anthony PERARD > > Cc: Christian Lindig > > Cc: David Scott > > Cc: George Dunlap > > Cc: Ian Jackson > > Cc: Nick Rosbrook > > Cc: Wei Liu