From: Chao Yu Subject: Re: [PATCH 04/13] f2fs: clear FI_INC_LINK during the recovery Date: Wed, 13 Aug 2014 18:18:13 +0800 Message-ID: <009c01cfb6e0$07d4f480$177edd80$@samsung.com> References: <1407872967-26423-1-git-send-email-jaegeuk@kernel.org> <1407872967-26423-4-git-send-email-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net To: 'Jaegeuk Kim' Return-path: In-reply-to: <1407872967-26423-4-git-send-email-jaegeuk@kernel.org> Content-language: zh-cn List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Wednesday, August 13, 2014 3:49 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 04/13] f2fs: clear FI_INC_LINK during the recovery > > If an inode are fsynced multiple times with fsync & dent marks, this inode will > set FI_INC_LINK at find_fsync_dnodes during the recovery. > But, in recover_inode, recover_dentry doesn't clear that flag when multiple hits > were occurred. > > So this patch removes the flag for the further consistency. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu > --- > fs/f2fs/recovery.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index fe1c6d9..cfb2aa9 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -62,8 +62,10 @@ static int recover_dentry(struct page *ipage, struct inode *inode) > } > retry: > de = f2fs_find_entry(dir, &name, &page); > - if (de && inode->i_ino == le32_to_cpu(de->ino)) > + if (de && inode->i_ino == le32_to_cpu(de->ino)) { > + clear_inode_flag(F2FS_I(inode), FI_INC_LINK); > goto out_unmap_put; > + } > if (de) { > einode = f2fs_iget(inode->i_sb, le32_to_cpu(de->ino)); > if (IS_ERR(einode)) { > -- > 1.8.5.2 (Apple Git-48) > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ------------------------------------------------------------------------------