From: "Namjae Jeon" Date: Tue, 09 Jun 2020 00:37:48 +0000 Subject: RE: [PATCH] exfat: Fix pontential use after free in exfat_load_upcase_table() Message-Id: <00a401d63df6$3370adc0$9a520940$@samsung.com> List-Id: References: <20200608141629.GA1912173@mwanda> In-Reply-To: <20200608141629.GA1912173@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Dan Carpenter' Cc: 'Sungjong Seo' , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, 'Tetsuhiro Kohada' > This code calls brelse(bh) and then dereferences "bh" on the next line resulting in a possible use > after free. The brelse() should just be moved down a line. > > Fixes: b676fdbcf4c8 ("exfat: standardize checksum calculation") > Signed-off-by: Dan Carpenter Applied. Thanks! > --- > fs/exfat/nls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exfat/nls.c b/fs/exfat/nls.c index c1ec056954974..57b5a7a4d1f7a 100644 > --- a/fs/exfat/nls.c > +++ b/fs/exfat/nls.c > @@ -692,8 +692,8 @@ static int exfat_load_upcase_table(struct super_block *sb, > index++; > } > } > - brelse(bh); > chksum = exfat_calc_chksum32(bh->b_data, i, chksum, CS_DEFAULT); > + brelse(bh); > } > > if (index >= 0xFFFF && utbl_checksum = chksum) > -- > 2.26.2