Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C6D9C433F5 for ; Wed, 5 Jan 2022 16:01:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E4B683055; Wed, 5 Jan 2022 17:01:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=aruba.it header.i=@aruba.it header.b="hoak48NU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 179B883055; Wed, 5 Jan 2022 17:01:00 +0100 (CET) Received: from smtpcmd11117.aruba.it (smtpcmd11117.aruba.it [62.149.156.117]) by phobos.denx.de (Postfix) with ESMTP id EA19082F89 for ; Wed, 5 Jan 2022 17:00:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=giulio.benetti@benettiengineering.com Received: from [192.168.50.18] ([146.241.138.59]) by Aruba Outgoing Smtp with ESMTPSA id 58iFnL0ynxyjb58ibntard; Wed, 05 Jan 2022 17:00:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1641398455; bh=dtepZTUlQrdn5q6IoJ/rK0s7u+a+sAXolKRo7WOMzGc=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=hoak48NUvJ74AqbqiowKSi7L01fvy1KSe/gH9wiiZdR+a+tSf5bCkw7pvTqRiqJMr 20bPt5VkKfA5gKyAhCrcxmHFpK8lwytdcjnZV00ZyESs+RGPCJ8+XTmS/2GTd0TM9N exXzv/MLNzluRCKK/iQAzqNz4YihMGBPfoRCxJRz6M/Csu02ojMaIgVclIhxrAFFZU uJa99tNeyTt+YZRz7veYCc0uhjr1OqocCzddrvwo1CKLE87WroFWxdeZ1ykD9dIp0i i6qTW0yQicV6DsVm7NQfANsT7BNAzmCdgCdYc54GLF97aL23WnT389yFmGt2TzrQlE s/AvgLpjH/DLA== Subject: Re: [PATCH 00/11] Add support for SUNIV and F1C100s. To: Jesse Taube , Andre Przywara , Icenowy Zheng Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, lokeshvutla@ti.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, thirtythreeforty@gmail.com References: <20220105003508.1143140-1-Mr.Bossman075@gmail.com> <16f1b5aed8b616547084c64d2ec4398446681392.camel@aosc.io> <20220105121415.2df58be3@slackpad.fritz.box> <8e85b8ea-d400-c3c1-4610-c88f5ed0510c@gmail.com> From: Giulio Benetti Message-ID: <00a7faf8-6e0c-7eb4-04cb-0a4ded26d3cf@benettiengineering.com> Date: Wed, 5 Jan 2022 17:00:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8e85b8ea-d400-c3c1-4610-c88f5ed0510c@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfEBm1Nsvl+Tbf7IxqDCJbsr57FlWnpPQ93hOO3uvieQv+aFabU6kgrFSF9Ft22uU0AVt1BfGUPXskOD15uS/5WjF6AL3dq3Gd6LWD9SfJnecANFGrDMG nQEn8BjrwKwKtvH/WkX3/xJEhdW55mFrooxoIbkaSj4fNZujeHd6qfTpcJMhoczi/jmwITeymXt521tD9+icfh6nU8Wus37typuJOKeI2VE1TtcGarNWY/oW U4rX0mcOCXvAB7fdRP5abi0myPt6MQTYXoLEw83vxbkMctRRI9R2bMJjG5mcWVoQXBO/uitr82TZ/rcDDr2HQnyA/2CJ2QQPOu16df0dhJx0ApdlNdzC0CFs trilaRikGaXBCFV6T1KlUCBjj1wRpzleXYuJm0zzya1GOPdD5LqoCnYWT9LCRljxv/JFRNc7Dg95WCC9KwFWqZ7H8rxt26Q8nvpVDNGv5B8L8Wr8P4cIaDkq uwuGCc1P+noNPqvFb1/fI3E3RZPEWv/qwoHESez/8Hm1lhxf8NMlBLdT7Dq1z1Xd8/5cURUfTusO17HKfX/k3jPgu99n/9gVN8bJZAhGpdX1J2xk9B7DeV3f aaIBpoGg/PTA2Jca7olhD5f3hjR2p38jyQTBiidykuBYf/KoZU7NfUNGh0WE4woxiAbRasl2CxpBR/cqpkD+5zOifDmlCOuvQrJb9w67aKQoaelcw/YKgjMH L7uMTw7ebRRhVZdViC3PA2nuYB49z33TzBbpwxLILbQlyiYu/KL5UewC5JNNpTUb8gyildXXVwA= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi All, On 05/01/22 13:54, Jesse Taube wrote: > > > On 1/5/22 07:14, Andre Przywara wrote: >> On Wed, 05 Jan 2022 19:36:29 +0800 >> Icenowy Zheng wrote: >> >> Hi Jesse, >> >>> 在 2022-01-04星期二的 19:34 -0500,Jesse Taube写道: >>>> This patch set aims to add suport for the SUNIV and F1C100s. >>>> Suport has been in linux for a while now, but not in u-boot. >>>> >>>> This patchset contains: >>>> - CPU specific initialization code >>>> - SUNIV dram driver >>>> - SUNIV clock driver adaption >>>> - SUNIV gpio driver adaption >>>> - SUNIV uart driver adaption >>>> - F1C100s basic support >>>> >>>> I am hoping to get Icenowy's patches in as it seems she hasnt >>>> submitted >>>> in a while. The only edits I made to her code is rebasing it against >>>> ML >>>> and changing some formating. I also re-grouped her commits. >>> >>> I got too lazy to send it (because I think F1C100s is just too weak)... >>> >>>> >>>> I am wondering if the dram driver should be moved into device drivers >>>> rather than in mach-sunxi. >>>> I am also wondering if it is okay to submit some one elses code, >>>> and if so how should I do so. >>> >>> As you are keeping my SoB and adding yours, it's totally okay. >> >> Thanks Icenowy for confirming! >> >> Jesse: yes, it's perfectly fine to send patches from someone else, as >> long as you keep the authorship, their SoB, and add your's. >> Typical reasons are lack of time or interest from the original author. >> >> But it's customary to ask the author first > I did but it must have gotten lost in the cosmos. > , and care should be taken >> when changing patches, as this might not be in the interest of the >> original author (and they are the ones who will get blamed for bugs). >> Also please mark the series either as a Resend or as a v2. >> >> So with Icenowy's confirmation above I consider this fine. >> >> But what was actually holding back this series was lack of review, >> testing and/or interest. > Well the price of the SOC has gained it some popularity, aswell as a > couple forum posts. >> Similar to Icenowy my personal interest in >> crufty old cores is somewhat limited, so this wasn't very high on my >> priority list. > It is very slow but its a good challenge. Slow depending on application :-) Two of my customers would like to use it in Q2/Q3 for very low-end HMIs. And as I see, one of the last F1Cxxx is F1C800s released in 2017. Here the good thing they have is ram onboard. >> >> So given that there is apparently some interest now: >> Can you confirm that you have reviewed the series, or at least tested >> this? > I have tested this yes. > I would be interested to know if a second pair of eyes had a >> look, and to what extent. > I'm Sending giulio.benetti@ some boards I made he will also test. I'm > sure many other people will be willing to test aswell. Yes, I'll test on Jesse's board and on Lichee-pi-nano too when I have time, this way I'll be able to give a Tested-by: me. Best regards -- Giulio Benetti Benetti Engineering sas >> I don't have any hardware, so would need to >> rely on others to make sure this code is somewhat sane. > I can send you one of my many boards :) >> And it basically looks like a v2 of Icenowy's series, so can you give a >> Changelog of the differences? I skimmed over her original series back >> then, so I would be interested in what makes this version special. > It passes checkpatch on the latest. >> >> Cheers, >> Andre >> >>> Thanks for cleaning up these patches! ;-) > NP! > > I took https://github.com/Lichee-Pi/u-boot/tree/nano-v2018.01 > re-based it against mainline and fixed formatting in a few files. > I also removed the spi-flash driver as it was causing issues and we can > boot from sdcard for now. there are some things I did to make the old > code compatible with new code but mostly preprocessor and configs. > > For the dram driver I had to change a bit but none of the logic, i am > worried that i may have to move it to /drivers. > > Do you want a more comprehensive list of changes? >