From: "cron2 (Code Review)" Date: Mon, 4 Aug 2025 13:37:22 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <00d0b8ab59a33482ef21ca6393d76906a9437e1a-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="bsMR4lSwxbc="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: GHA: enable -Werror for mbedTLS v3 and AWS LC builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --bsMR4lSwxbc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1128?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds ...................................................................... GHA: enable -Werror for mbedTLS v3 and AWS LC builds Because we can and so we should. Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e Signed-off-by: Frank Lichtenheld Acked-by: Yuriy Darnobyt Message-Id: <20250804133413.24729-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 505.html Signed-off-by: Gert Doering --- M .github/workflows/build.yaml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1128/2 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index bd5895b..a499e1c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=3Dmbedtls + run: ./configure --with-crypto-library=3Dmbedtls --enable-werror - name: make all run: make -j3 - name: configure checks @@ -489,7 +489,7 @@ OPENSSL_CFLAGS=3D"-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS=3D"-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto"= \ LDFLAGS=3D"-Wl,-rpath=3D/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl + ./configure --with-crypto-library=3Dopenssl --enable-werror - name: make all run: make -j3 - name: configure checks -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e Gerrit-Change-Number: 1128 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --bsMR4lSwxbc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by uddr

GHA: enable -Werror for mbedTLS v3 and AWS LC builds<=
br>
Because we can and so we should.

Change-Id: I9159e2e354170ad6= dbed5a6ce620f57fa8ab128e
Signed-off-by: Frank Lichtenheld <frank@...1665...= 641...>
Acked-by: Yuriy Darnobyt <yura.uddr@...277...>
Messa= ge-Id: <20250804133413.24729-1-gert@...1296...>
URL: https://www.m= ail-archive.com/openvpn-devel@lists.sourceforge.net/msg32505.html
Signed= -off-by: Gert Doering <gert@...1296...>
---
M .github/workflows= /build.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

gi=
t pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1128/2
<= pre style=3D"font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml<= /span>
index bd5895b..a499e1c 100644
--- a/.github= /workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -425,7 +425,7 @@
- name: autoconf
run: autoreconf -fvi
- name:= configure
- run= : ./configure --with-crypto-library=3Dmbedtls
+ run: ./configure --with-crypto-library=3D= mbedtls --enable-werror
- name: make all
<= span> run: make -j3

- name: configure checks=
@@ -489,7 +489,7 @@
OPENSSL_CFL= AGS=3D"-I/${{ env.AWS_LC_INSTALL }}/include" \
= OPENSSL_LIBS=3D"-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcryp= to" \
LDFLAGS=3D"-Wl,-rpath=3D/${{ env= .AWS_LC_INSTALL }}/lib" \
- ./configure --with-crypto-library=3Dopenssl
+ ./configure --with-cry= pto-library=3Dopenssl --enable-werror

- name: make a= ll
run: make -j3
- name: co= nfigure checks

To view, visit change 1128= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce62= 0f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: uddr <yura.uddr@...277...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--bsMR4lSwxbc=--