From: Jongsun Han Subject: RE: [PATCH V2 2/2] ARM: S5PV310: Add support GPIOlib Date: Fri, 15 Oct 2010 08:55:03 +0900 Message-ID: <00e201cb6bfb$38aaebc0$aa00c340$%han@samsung.com> References: <1286868876-3748-1-git-send-email-sbkim73@samsung.com> <1286868876-3748-3-git-send-email-sbkim73@samsung.com> <006501cb6b5f$f9bd29a0$ed377ce0$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:21772 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754603Ab0JNXyD (ORCPT ); Thu, 14 Oct 2010 19:54:03 -0400 Received: from epmmp2 (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0LAB0020Q121O0C0@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 15 Oct 2010 08:54:01 +0900 (KST) Received: from JONGSUNHA4 ([12.23.102.141]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPSA id <0LAB0086E121TM@mmp2.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 15 Oct 2010 08:54:01 +0900 (KST) In-reply-to: <006501cb6b5f$f9bd29a0$ed377ce0$%kim@samsung.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Kukjin Kim' , 'Sangbeom Kim' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: 'Jongpill Lee' , ben-linux@fluff.org Sangbeom Kim wrote: > > > > From: Jongpill Lee > > > > This patch adds GPIOlib support for S5PV310 and S5PC210. > > > > Signed-off-by: Jongpill Lee > > Signed-off-by: Sangbeom Kim > > --- > > NOTE: > > This patch used mapped VA IO as GPIO virtual address. > > because firstly other Samsung SoC's GPIO used same method. > > and I think that it's better to keep the same method. > > And ioremap also can be used for it. > > But in the GPIO, there is no need to allocate VA area dynamically. > > because GPIO can be used in any drivers anytime so it can't iounmap GPIO > > VA area. > > > Ok... > > (snip) > > > #define MAX_COMBINER_NR 40 > > > > +#define S5P_IRQ_EINT_BASE COMBINER_IRQ(MAX_COMBINER_NR, 0) > > + > > +#define S5P_EINT_BASE1 (S5P_IRQ_EINT_BASE + 0) > > +#define S5P_EINT_BASE2 (S5P_IRQ_EINT_BASE + 16) > > + > > Hmm... > If you want to add external interrupt, should be changed NR_IRQS too. > > Will apply with fixing NR_IRQS. > It seems that S5P_IRQ_EINT_BASE has wrong definition. S5P_IRQ_EINT_BASE has to be COMBINER_IRQ(MAX_COMBINER_NR - 1, 0). Thanks. > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel