Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414D5C433DF for ; Thu, 11 Jun 2020 12:08:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BF6920760 for ; Thu, 11 Jun 2020 12:08:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sAwGtmfq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BF6920760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjLzy-0001nH-AU; Thu, 11 Jun 2020 12:07:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjLzx-0001nC-QL for xen-devel@lists.xenproject.org; Thu, 11 Jun 2020 12:07:57 +0000 X-Inumbo-ID: 2f649fa8-abdc-11ea-bca7-bc764e2007e4 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f649fa8-abdc-11ea-bca7-bc764e2007e4; Thu, 11 Jun 2020 12:07:57 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id r9so4750629wmh.2 for ; Thu, 11 Jun 2020 05:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=SQjfCLhpn1aUhJIKbYJH4jjv4xfDX96+6/uKPZYtr+o=; b=sAwGtmfq85dRn88LA//XkcFUWnRvB/6KSXq2BHr1bQa6dj/RETp6lJtKWsSP+J5U2t TEenVL4nt8npCpzDwYBAdVL2hGGjAvkiFz0zuFtNaELEIsnpH4i9PiPl2fSHzzVw17xv J8OUNZFKoeXrYdIuZ2X409oZ4ieMYRwPPRKvpsnvxU/zwnjqPvIKiDcBpP6zrddJqjk2 j5EvC03XyL29sTQiNExsjD5DnlJ0cysFLj+jpJ4umQYNosYvUVazLoKUgcwZhf5ezYkZ HdlRo7MpDobI1XTVlRiLDe8tyAnD1nwfXEs9B0LIQURP1MHj1ukco7JiqioPwHlVLbOy vdvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=SQjfCLhpn1aUhJIKbYJH4jjv4xfDX96+6/uKPZYtr+o=; b=Q8SbaL1wso5yQvnb+/FthndjK0lnXgikXUtdJpIoIv+SN/9Kq2ww2pzxdP70lMvjlA 8BKbffVVwdTHR4Dr97rbQMTfkQNo1TA+Ryz9kQFVkApV2it+BzkST6yIu6DRIfBH9dmi 3EgcPLsqK3kr9D9JzxtMKT4o9m1F5c/na67rYhZ5X0cePbEc6cmLajjlO3rCsGfn4Q3t QY4sMwi4OILLddgAtmS6jOAb5YIMYgXmxSKOO3U+yhQHIWQii4L3J4zafxzuZ/uN6g64 gBJEF9QVK5alAiGOY6MpRaLR+831deQf5XE0mzAQ/JRmmVB9dnZpM545vcEVaW6RRok/ wFqg== X-Gm-Message-State: AOAM530f1rYpqXhbNaIzfzBd+xeu7sDeMh5McLcb4KgqGp2H3E4XdJ0y QEHvmfraNyOtAWhD/uST1XM= X-Google-Smtp-Source: ABdhPJwXLXJ1OV07e/4hbQ1MSCcH+zpoui0yVnQ3aKm4JrukvxzwuI2aJkl5xHTJ5TuNZFDspVglMw== X-Received: by 2002:a1c:6244:: with SMTP id w65mr7857843wmb.82.1591877276115; Thu, 11 Jun 2020 05:07:56 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.177]) by smtp.gmail.com with ESMTPSA id q1sm3751244wmc.15.2020.06.11.05.07.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2020 05:07:55 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Andrew Cooper'" , "'Jason Andryuk'" , References: <20200611035518.379297-1-jandryuk@gmail.com> In-Reply-To: Subject: RE: [PATCH] libacpi: Widen TPM detection Date: Thu, 11 Jun 2020 13:07:50 +0100 Message-ID: <00e801d63fe8$f0682d10$d1388730$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQD+75p+LtrZduM9I2CZ2QpfMgSpTQIvmX2vqnB1jmA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Ian Jackson' , 'Jan Beulich' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Andrew Cooper > Sent: 11 June 2020 12:52 > To: Jason Andryuk ; xen-devel@lists.xenproject.org > Cc: Ian Jackson ; Wei Liu ; Jan Beulich ; > Paul Durrant > Subject: Re: [PATCH] libacpi: Widen TPM detection > > On 11/06/2020 04:55, Jason Andryuk wrote: > > The hardcoded tpm_signature is too restrictive to detect many TPMs. For > > instance, it doesn't accept a QEMU emulated TPM (VID 0x1014 DID 0x0001). > > Make the TPM detection match that in rombios which accepts a wider > > range. > > > > With this change, the TPM's TCPA ACPI table is generated and the guest > > OS can automatically load the tpm_tis driver. It also allows seabios to > > detect and use the TPM. However, seabios skips some TPM initialization > > when running under Xen, so it will not populate any PCRs unless modified > > to run the initialization under Xen. > > > > Signed-off-by: Jason Andryuk > > Reviewed-by: Andrew Cooper > > This looks like it wants backporting, so CC'ing Paul for a 4.14 release ack. Agreed. Release-acked-by: Paul Durrant