Received: from eggs.gnu.org ([2001:4830:134:3::10]:33335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1x6K-0000KY-AL for qemu-devel@nongnu.org; Wed, 02 Nov 2016 11:05:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1x6F-0007oL-W1 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 11:05:16 -0400 References: <1461706338-20219-1-git-send-email-mreitz@redhat.com> From: Max Reitz Message-ID: <00eb82df-3064-8e01-103b-fa95f2101e08@redhat.com> Date: Wed, 2 Nov 2016 16:05:01 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s4wVVfBSRi07c7JGr14oU3DDrvNwOMwbV" Subject: Re: [Qemu-devel] [PATCH 00/19] block: Fix some filename generation issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Eric Blake , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s4wVVfBSRi07c7JGr14oU3DDrvNwOMwbV From: Max Reitz To: Alberto Garcia , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Eric Blake , Kevin Wolf Message-ID: <00eb82df-3064-8e01-103b-fa95f2101e08@redhat.com> Subject: Re: [PATCH 00/19] block: Fix some filename generation issues References: <1461706338-20219-1-git-send-email-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 02.11.2016 16:00, Alberto Garcia wrote: > On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote: >=20 >> There are some issues regarding filename generation right now: >> >> - You always get a JSON filename if you set even a single qcow2-specif= ic >> runtime options (as long as it does not have a dot in it, which is a= >> bug, too, but here it is working in our favor...). That is not nice >> and actually breaks the usage of backing files with relative >> filenames with such qcow2 BDS. >> >> - As hinted above, you cannot use relative backing filenames with BDS >> that have a JSON filename only, even though qemu might be able to >> obtain the directory name by walking through the BDS graph to the >> protocol level. >> >> - Overriding the backing file at runtime should invalidate the filenam= e >> because it actually changes the BDS's data. Therefore, we need to >> force a JSON filename in that case, containing the backing file >> override. >> >> - Much of our code assumes paths never to exceed PATH_MAX in length. >> This is wrong, at least because of JSON filenames. This should be >> fixed wherever the opportunity arises. >=20 > Hi Max, >=20 > I'd like to retake the review of this series. It can be rebased easily > and it still seems to work fine. Shall I take a look at the patches as > they are now or shall I better wait for a new version? Thanks! I think it would be better to wait for a new version, which I'll get to hopefully sooner than later. Max --s4wVVfBSRi07c7JGr14oU3DDrvNwOMwbV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJYGgCdEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQKMP B/9K+IDC+XJ7J9DfSsK+dAzyPGMoxSlQ8JMcmU7kWOoF8qljh9kyuxr5ne5bPoqO J0YolBGxkDS5YF2k2xE4Ctn9+TarOzCOHYu5q+gwNbUXF3tHRKaIOdbkbd/emhPg LoJLdpTEpx1YVcRFm1vr4k7LmoDKLN4AfuQ/AnPgaBsn3OkZe2jRb8Xg6oukJBpL zejA28ujOKhb6K+rIHrzax/UyC/hK12Vq5FU4EDJdLoizZoHrAu4O/bkuCmZZXmi yGCo8MW8ntCKxC83GTMPoGOXc83L2/ceqjx8Gd1geH6k65EHaQGCs/6Y/+Wll1Im P8iPws60wtZvNJkaIFzatfQx =oh58 -----END PGP SIGNATURE----- --s4wVVfBSRi07c7JGr14oU3DDrvNwOMwbV--