Received: from eggs.gnu.org ([2001:4830:134:3::10]:46779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXktL-0001Vd-NL for qemu-devel@nongnu.org; Fri, 04 Sep 2015 02:54:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXktH-0004Xa-M0 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 02:54:31 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXktH-0004XS-Gc for qemu-devel@nongnu.org; Fri, 04 Sep 2015 02:54:27 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NU5008ZK4IP9I10@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 04 Sep 2015 07:54:25 +0100 (BST) From: Pavel Fedin References: <5f481e4c8a35808c7e4a511100f9417d75b49670.1440584396.git.p.fedin@samsung.com> In-reply-to: Date: Fri, 04 Sep 2015 09:54:23 +0300 Message-id: <012101d0e6de$88ed5dd0$9ac81970$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Peter Maydell' Cc: 'Shlomo Pongratz' , 'Shlomo Pongratz' , 'QEMU Developers' , 'Eric Auger' Hello! > > + > > +#define kvm_gicd_access(s, offset, cpu, val, write) \ > > + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_DIST_REGS, \ > > + KVM_VGIC_ATTR(offset, cpu), val, write) > > + > > +#define kvm_gicc_access(s, offset, cpu, val, write) \ > > + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_CPU_REGS, \ > > + KVM_VGIC_ATTR(offset, cpu), val, write) >=20 > Can you make these two static inline functions, not #defines, please? I can, of course, and i did in previous versions, but you disliked it = because inline functions would require dev_fd instead of 's', because = 's' is different in GICv2 and GICv3. Macro approach allowed to work = around this difference. Or do you mean you strictly don't want them to = be reusable? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia