Received: from eggs.gnu.org ([2001:4830:134:3::10]:56397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwtbF-0002T0-Tr for qemu-devel@nongnu.org; Mon, 25 May 2015 10:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ywtb9-00042L-PU for qemu-devel@nongnu.org; Mon, 25 May 2015 10:43:29 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:43648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywtb9-00041y-J7 for qemu-devel@nongnu.org; Mon, 25 May 2015 10:43:23 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NOW004S9U87Y370@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 25 May 2015 15:43:19 +0100 (BST) From: Pavel Fedin References: <55632C9A.6000005@linaro.org> In-reply-to: <55632C9A.6000005@linaro.org> Date: Mon, 25 May 2015 17:43:18 +0300 Message-id: <012701d096f9$240f4cf0$6c2de6d0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ru Subject: Re: [Qemu-devel] [PATCH RFC 2/4] Set kernel_irqchip_type for other ARM boards which use GIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Eric Auger' , qemu-devel@nongnu.org Cc: 'Shlomo Pongratz' , 'Ashok Kumar' Hello! > > +++ b/hw/arm/exynos4_boards.c > > @@ -104,6 +104,7 @@ static Exynos4210State > *exynos4_boards_init_common(MachineState *machine, > > exynos4_machines[board_type].max_cpus); > > } > > > > + machine->kernel_irqchip_type = KVM_DEV_TYPE_ARM_VGIC_V2; > Are you sure this machine is able to use in-kernel GICv2? I'm not. I just scanned all machine sources for "GIC" string and added this wherever it was found. Actually it is harmless. If the machine cannot use in-kernel VGIC, it will just not use it. Ok, i will know this for the future. Actually i would like to wait for Shlomo's patch integration, because otherwise i violate the main rule "the patchset should apply to current master", and i believe it's not good to specify that "this patches applies on top of YYY one". Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia