From: "Fish Wang" References: <1449794790-45430-1-git-send-email-fish.thss@...277...> In-Reply-To: Date: Sun, 13 Dec 2015 16:20:03 -0800 Message-ID: <014001d13605$2dec6ae0$89c540a0$@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0141_01D135C2.1FC9C720" Content-Language: zh-cn Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Selva Nair' Cc: openvpn-devel@lists.sourceforge.net This is a multipart message in MIME format. ------=_NextPart_000_0141_01D135C2.1FC9C720 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi all, =20 A minor suggestion: All those prototypes taken from mingw (32 or -w64?)=20 may be better placed in new header file to be included only from win32.c --= =20 -- preferably with a license matching the source (PD or ZPL?). Makes win32.c less cluttered as well. =20 Will do. However, I=E2=80=99m by no means a license expert. Based on Licens= ing Terms page on MinGW=E2=80=99s website ([1], win32api), I believe the co= de I stripped out of MinGW should be fine as long as a copy of the notice a= nd its license [2] is included. Please correct me if I=E2=80=99m wrong. =20 Best, Fish =20 [1] http://www.mingw.org/license [2] http://sourceforge.net/p/mingw/mingw-org-wsl/ci/21762bb4a1bd0c88c38eead= 03f59e8d994349e83/tree/LICENSE =20 From: Selva Nair [mailto:selva.nair@...277...]=20 Sent: Sunday, December 13, 2015 1:14 PM To: Fish Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform = agnostic =20 Hi, On Thu, Dec 10, 2015 at 7:46 PM, Fish > wrote: Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it un= der MSVC. =20 Builds on 2.3 out of the box (i.e., target WINXP). The implementation looks fine, and works on win7 and 10, but I've=20 no XP machines for the crucial test. A minor suggestion: All those prototypes taken from mingw (32 or -w64?)=20 may be better placed in new header file to be included only from win32.c --= =20 -- preferably with a license matching the source (PD or ZPL?). Makes win32.c less cluttered as well.=20 I'm not familiar with the policy of OpenVPN on license-related=20 matters, though. =20 Selva ------=_NextPart_000_0141_01D135C2.1FC9C720 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi all,

=  

A minor suggestion: All those pr= ototypes taken from mingw (32 or -w64?)
may be better placed in new hea= der file to be included only from win32.c --
-- preferably with a licen= se matching the source (PD or ZPL?).  Makes
win32.c less cluttered = as well.

&= nbsp;

Will do. Howev= er, I=E2=80=99m by no means a license expert. Based on Licensing Terms page= on MinGW=E2=80=99s website ([1], win32api), I believe the code I stripped = out of MinGW should be fine as long as a copy of the notice and its license= [2] is included. Please correct me if I=E2=80=99m wrong.=

 

Best,

Fish

 

[1] http://www.mingw.org/license

[2] http://sourceforge.net/p/mingw/mingw-org-wsl/= ci/21762bb4a1bd0c88c38eead03f59e8d994349e83/tree/LICENSE<= /p>

 

From: Selva Nair [mailto:selva.nair@...220...= ..277...]
Sent: Sunday, December 13, 2015 1:14 PM
To: = Fish <fish.thss@...277...>
Cc: openvpn-devel@...1357...= rge.net
Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS = leak fix platform agnostic

 

Hi,

On Thu, Dec 10, 2015 a= t 7:46 PM, Fish <fish.thss@...277...> wrote:

Based on release/2.3 branch and ValdikSS's v9 patch, this patch is
= cross-compiled on Linux and tested on Windows XP/10. The VC project file is=
left untouched - you might want to add rpcrt4.lib to compile and link i= t under
MSVC.

 

Builds on 2.3 out of the box (i.e., target&= nbsp; WINXP).

The implementation looks fine, an= d works on win7 and 10, but I've
no XP machines for the crucial test.

A mi= nor suggestion: All those prototypes taken from mingw (32 or -w64?)
may= be better placed in new header file to be included only from win32.c -- -- preferably with a license matching the source (PD or ZPL?).  Make= s
win32.c less cluttered as well.

I'm not familiar with the poli= cy of OpenVPN on license-related
matters, though.

=

 =

Selva

= ------=_NextPart_000_0141_01D135C2.1FC9C720--