From: "Kasai Takanori" Subject: Re: [PATCH] qemu-dm monitor doesn't support the quit command Date: Wed, 17 Jan 2007 12:05:09 +0900 Message-ID: <014201c739e4$4d4913b0$dab2220a@VF03007L> References: <15d001c725ca$326f3980$dab2220a@VF03007L><07ff01c727c6$ac8c1d20$dab2220a@VF03007L><103201c73463$e6af4000$dab2220a@VF03007L><20070110033427.GD6153@edwin-srv.sh.intel.com> <144c01c73578$742b2240$dab2220a@VF03007L> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_013F_01C73A2F.BBC65640" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. ------=_NextPart_000_013F_01C73A2F.BBC65640 Content-Type: text/plain; format=flowed; charset="iso-2022-jp"; reply-type=response Content-Transfer-Encoding: 7bit Hi All, I made the patch that changed it from quit or q to quitdomain. I think that the HVM domain can be prevented being shutted down by the mistake in this patch. If there is any problem, please let me know. >> quit command is useful when we have no host console(e.g. qemu window on a >> remote >> X). and it's a normal exit that is different from xm destroy(by KILL sig). >> >> maybe we can change "q" to "quit" to avoid typo? or provide confirm info? >> >> BTW, "q" is most popular command when we debug qemu device model:) > > I understood the "quit" or "q" command was necessary for debugging. > However, there is a possibility that the user shuts down the HVM domain by > mistake. > > Cannot you change "quit" or "q" to "quitdomain"? Thanks, -- Takanori Kasai ------=_NextPart_000_013F_01C73A2F.BBC65640 Content-Type: application/octet-stream; name="qemu-monitor-quitdomain.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="qemu-monitor-quitdomain.patch" # HG changeset patch=0A= # User kasai.takanori@jp.fujitsu.com=0A= # Date 1169002068 -32400=0A= # Node ID fa6a0785562dc576933f82aceab43628a877dbc0=0A= # Parent 895d873a00b47cb7b0edf3d0b6a42f47a3f4854c=0A= quit or q command is changed to the quitdomain on qemu-dm monitor=0A= =0A= Signed-off-by: Takanori Kasai =0A= =0A= diff -r 895d873a00b4 -r fa6a0785562d tools/ioemu/monitor.c=0A= --- a/tools/ioemu/monitor.c Tue Jan 16 10:02:50 2007 +0000=0A= +++ b/tools/ioemu/monitor.c Wed Jan 17 11:47:48 2007 +0900=0A= @@ -1158,7 +1158,7 @@ static term_cmd_t term_cmds[] =3D {=0A= "", "commit changes to the disk images (if -snapshot is used)" },=0A= { "info", "s?", do_info,=0A= "subcommand", "show various information about the system state" },=0A= - { "q|quit", "", do_quit,=0A= + { "quitdomain", "", do_quit,=0A= "", "quit the emulator" },=0A= { "eject", "-fB", do_eject,=0A= "[-f] device", "eject a removable media (use -f to force it)" },=0A= ------=_NextPart_000_013F_01C73A2F.BBC65640 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel ------=_NextPart_000_013F_01C73A2F.BBC65640--