From: Kukjin Kim Subject: RE: [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support Date: Thu, 07 Mar 2013 10:17:15 +0900 Message-ID: <015101ce1ad1$80e4fa20$82aeee60$%kim@samsung.com> References: <016b01ce18c2$2c366f10$84a34d30$%han@samsung.com> <20130306140752.7e5d68c8@skate> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20130306140752.7e5d68c8@skate> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Thomas Petazzoni' , 'Thomas Abraham' Cc: 'Jingoo Han' , linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, 'Surendranath Gurivireddy Balla' , 'Siva Reddy Kallam' List-Id: devicetree@vger.kernel.org Thomas Petazzoni wrote: > > Dear Thomas Abraham, > > On Mon, 4 Mar 2013 16:01:59 +0530, Thomas Abraham wrote: > > On 4 March 2013 15:52, Jingoo Han wrote: > > > Exynos5440 has two PCIe controllers which can be used as Root Complex. > > > This driver supports the PCIe controllers as Root Complex mode. > > > > > > Signed-off-by: Surendranath Gurivireddy Balla > > > > Signed-off-by: Siva Reddy Kallam > > > Signed-off-by: Jingoo Han > > > --- > > > .../devicetree/bindings/pci/exynos-pcie.txt | 58 ++ > > > arch/arm/Kconfig | 2 + > > > arch/arm/mach-exynos/Kconfig | 8 + > > > arch/arm/mach-exynos/Makefile | 2 + > > > arch/arm/mach-exynos/include/mach/pcie.h | 146 +++ > > > arch/arm/mach-exynos/pcie.c | 1009 > ++++++++++++++++++++ > > > > Is there any reason to place this code in arch/arm/...? As you know, > > there is a constant effort to relocate as much code as possible from > > arch/arm/mach-exynos. So there must be a strong justification for > > keeping this code in arch/arm/mach-exynos. > > Indeed. Thierry Reding (doing the Tegra PCIe driver) and myself (doing > the Marvell PCIe driver) are putting our drivers in drivers/pci/host/, > in agreement with the PCI maintainers. > I agree. Jingoo, please move this stuff into drivers/pci when you address comments. Thanks. - Kukjin