From: "Fish Wang" References: <1449794790-45430-1-git-send-email-fish.thss@...277...> <014001d13605$2dec6ae0$89c540a0$@gmail.com> In-Reply-To: Date: Sun, 13 Dec 2015 17:20:43 -0800 Message-ID: <015d01d1360d$a7c93070$f75b9150$@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_015E_01D135CA.99A665A0" Content-Language: zh-cn Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Selva Nair' Cc: openvpn-devel@lists.sourceforge.net This is a multipart message in MIME format. ------=_NextPart_000_015E_01D135CA.99A665A0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable You are absolutely right, the code I grabbed is indeed from mingw-w64, not = MinGW. Let me send out another patch with mingw-w64=E2=80=99s disclaimer so= on. I=E2=80=99ll see what core people says about this patch. =20 Thanks! =20 Best, Fish =20 From: Selva Nair [mailto:selva.nair@...277...]=20 Sent: Sunday, December 13, 2015 5:09 PM To: Fish Wang Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform = agnostic =20 Hi, On Sun, Dec 13, 2015 at 7:20 PM, Fish Wang > wrote: Will do. However, I=E2=80=99m by no means a license expert. Based on Licens= ing Terms page on MinGW=E2=80=99s website ([1], win32api), I believe the co= de I stripped out of MinGW should be fine as long as a copy of the notice a= nd its license [2] is included. Please correct me if I=E2=80=99m wrong. I thought those headers are from the mingw-w64 (a different code base from mingw32)..=20 Anyway, I did not mean to imply any licensing issues with extracting=20 parts from mingw32 or mingw-w64 --- both have permissive licenses=20 so there is no clash. However, some GPL projects have clear guidelines=20 of how to incorporate code from other licenses.=20 Personally I prefer to keep public domain code (and minor edits to it)=20 in a separate file which clearly indicates its in PD with the original=20 notice so that one wouldn't slap on a GPL header on it later. While=20 some projects want all their additions to be GPL keeping the original=20 in PD etc..(Fro example, see various practices disscussed in=20=20 https://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.pd= f). Better wait for a core developer to comment on this.. Selva ------=_NextPart_000_015E_01D135CA.99A665A0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

You are absolutely right, the code I grabbed is indeed from mingw-w64, no= t MinGW. Let me send out another patch with mingw-w64=E2=80=99s disclaimer = soon. I=E2=80=99ll see what core people says about this patch.

 

Thanks!

 

Best,

Fish

 

From: Selva Nair [mailto:selva.nair@...277...]
Sent: Sunday,= December 13, 2015 5:09 PM
To: Fish Wang <fish.thss@...277...&= gt;
Cc: openvpn-devel@lists.sourceforge.net
Subject: Re= : [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

 

<= span lang=3DEN-US>Hi,


I thought those headers are from the mingw-w64 (a different = code base
from mingw32)..

Anyway, I did not mean to imply any li= censing issues with extracting
parts from mingw32 or mingw-w64 --- both= have permissive licenses
so there is no clash. However, some GPL proje= cts have clear guidelines
of how to incorporate code from other license= s.

Personally I prefer to keep public domain code (and minor edits = to it)
in a  separate file which clearly indicates its in PD with = the original
notice so that one wouldn't slap on a GPL header on it lat= er. While
some projects want all their additions to be GPL keeping the = original
in PD etc..(Fro example, see various practices disscussed in&n= bsp;
https://www.softwarefreedom.org/re= sources/2007/gpl-non-gpl-collaboration.pdf).

Better wait for a core developer to comment on this..

Selva

= ------=_NextPart_000_015E_01D135CA.99A665A0--