Received: from eggs.gnu.org ([2001:4830:134:3::10]:44073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPqHo-0003mI-A0 for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPqHk-00071h-8a for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:03:04 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:30915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPqHj-0006xf-VO for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:03:00 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NT000CUNPCXJF00@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 13 Aug 2015 12:02:57 +0100 (BST) From: Pavel Fedin References: In-reply-to: Date: Thu, 13 Aug 2015 14:02:56 +0300 Message-id: <016401d0d5b7$9c3bca80$d4b35f80$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v8 5/5] Add gicversion option to virt machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Peter Maydell' Cc: 'Shlomo Pongratz' , 'Shlomo Pongratz' , 'QEMU Developers' , 'Christoffer Dall' , 'Eric Auger' Hello! I am now finishing v9 and (i hope) i fixed everything except this one. = Sorry, too many mails, i occasionally skipped this one earlier. > Any particular reason for having two separate VIRT_ITS_* > entries? The spec mandates that the two 64K pages of ITS > have to be consecutive, so it would make life easier for > boards if they were just a single memory region. Yes, there is a reason. It is because of how in-kernel vITS works. It = handles only control region. Translation register has to be handled in = userspace and writes there need to be converted to KVM_SIGNAL_MSI ioctl. = Therefore two regions are more convenient to use. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia