Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF16EC18E5B for ; Tue, 17 Mar 2020 11:49:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ECD32051A for ; Tue, 17 Mar 2020 11:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QDC7Ump+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ECD32051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 97D3A186D; Tue, 17 Mar 2020 12:49:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 97D3A186D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584445795; bh=9wgPCt/KTGu5VvnVXgNErIdNQetOFPD5A2oo/Ge99yw=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QDC7Ump+mbXp/f6BlnA/KU0MxqC/KAKdPyxXGQ1XcBP4OlcTNajllnwFRBQK9H9tg +SuyYiHFEdB421ud6/C324BKDPJY1oYiHecIfZdudZWZfNPbcZ1mpyw92xD9pvYtbt 0OxcV2tav45lHBFNQvOwZV8u834mWCZw8ae+wBBE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A5997F8028B; Tue, 17 Mar 2020 12:47:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20671F8022B; Tue, 17 Mar 2020 12:46:14 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 97AE8F800CD for ; Tue, 17 Mar 2020 12:46:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 97AE8F800CD IronPort-SDR: iG4C5kH2FuD5EWqtTBZ5f1gOdget6cgm23CQTL3GlPn+mZ6CFAD3VIbhxyJnHmxbTftB1+HgNu +slk1I65nZnA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 04:46:05 -0700 IronPort-SDR: 85DD+Lo+DeY13g4opoIKZWuO/Db+kcrLR/J3xeyBSozpNwkVvxwGr8X38Eh8+QI38gCaC8K6dS 3PP/Zlpx+7iw== X-IronPort-AV: E=Sophos;i="5.70,564,1574150400"; d="scan'208";a="417517021" Received: from mgorski-mobl.ger.corp.intel.com (HELO [10.251.3.203]) ([10.251.3.203]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 04:46:04 -0700 Subject: Re: [PATCH v2] ucm2: hdadsp: add basic ucm config To: Jaroslav Kysela , alsa-devel@alsa-project.org References: <20200313110018.5145-1-mateusz.gorski@linux.intel.com> From: "Gorski, Mateusz" Message-ID: <01939d67-a263-e317-ac77-f4e8cc65f8de@linux.intel.com> Date: Tue, 17 Mar 2020 12:46:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: pl Cc: cezary.rojewski@intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Basic UCM configuration for Intel Skylake SST HDA DSP generic machine >> driver enabling codec playback and capture on both HDA codec and DMIC >> ports. >> >> Signed-off-by: Mateusz Gorski >> --- > > ... > >> +SectionDevice."Headphones" { >> +    Comment "Headphones" >> + >> +    ConflictingDevice [ >> +        "Speaker" >> +    ] >> + >> +    EnableSequence [ >> +        cset "name='Headphone Playback Switch' 1,1" >> +        cset "name='Speaker Playback Switch' 0,0" >> +    ] >> + >> +    Value [ >> +        PlaybackPriority 200 >> +        PlaybackPCM "hw:${CardId},7" >> +        JackControl "Front Headphone Jack" >> +        JackHWMute "Speaker" >> +    ] >> +} > > If there is a volume control, it should be defined via > PlaybackMixerElem (like PlaybackMixerElem "Headphone"). Thanks, added in v3. > >> +ValueDefaults { >> +        PlaybackChannels "2" >> +        CaptureChannels "2" >> +} > > This ValueDefaults {} section with this contents should be removed. > The stereo is the default settings. > >                         Jaroslav > Thanks, removed in v3.