Return-Path: Message-ID: <01ae626c-9316-4fd6-65be-41e229fd6316@linux.alibaba.com> Date: Wed, 11 Jan 2023 11:22:51 +0800 MIME-Version: 1.0 Subject: Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash From: Heng Qi References: <20230104071401.31746-1-hengqi@linux.alibaba.com> <20230106002431-mutt-send-email-mst@kernel.org> <20230106064221.GA61196@h68b04307.sqa.eu95> <20230106015425-mutt-send-email-mst@kernel.org> <20230109024341.GA85179@h68b04307.sqa.eu95> <20230109062943-mutt-send-email-mst@kernel.org> <20230110002017-mutt-send-email-mst@kernel.org> <20230110005158-mutt-send-email-mst@kernel.org> <20230110072652.GA31460@h68b04307.sqa.eu95> In-Reply-To: <20230110072652.GA31460@h68b04307.sqa.eu95> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit To: "Michael S. Tsirkin" Cc: Jason Wang , virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, Yuri Benditovich , Cornelia Huck , Xuan Zhuo List-ID: 在 2023/1/10 下午3:26, Heng Qi 写道: > On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: >> On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: >>>> This will give extra pressure on the management stack, e.g it requires >>>> the device to have an out of spec way for introspection. >>>> >>>> Thanks >>> As I tried to explain this is already the case. Feature bits do not >>> describe device capabilities fully, some of them are in config space. >> To be precise, this does not necessarily require introspection, but >> it does require management control over config space >> such as supported hash types just like it has control over feature bits. >> E.g. QEMU currently seems to hard-code these to >> #define VIRTIO_NET_RSS_SUPPORTED_HASHES (VIRTIO_NET_RSS_HASH_TYPE_IPv4 | \ >> VIRTIO_NET_RSS_HASH_TYPE_TCPv4 | \ >> VIRTIO_NET_RSS_HASH_TYPE_UDPv4 | \ >> VIRTIO_NET_RSS_HASH_TYPE_IPv6 | \ >> VIRTIO_NET_RSS_HASH_TYPE_TCPv6 | \ >> VIRTIO_NET_RSS_HASH_TYPE_UDPv6 | \ >> VIRTIO_NET_RSS_HASH_TYPE_IP_EX | \ >> VIRTIO_NET_RSS_HASH_TYPE_TCP_EX | \ >> VIRTIO_NET_RSS_HASH_TYPE_UDP_EX) >> >> but there's no reason not to give management control over these. > Yes, QEMU has requirements for live migration: the PCI config space will be > checked in get_pci_config_device(), and if src and dst are inconsistent, it > will prompt that the live migration failed. To be clearer, I mean \filed{supported_hash_types} in structure virtio_net_config. Thanks. > In fact, this is also done within our group. Live migration requires that > the two VMs have the same rss configuration, otherwise the migration will fail. > > Therefore, it seems that we can regularize the description of VIRTIO_NET_F_HASH_TUNNEL into > "[VIRTIO_NET_F_HASH_TUNNEL(52)] Device supports inner header hash for tunnel-encapsulated packets.", > and use different hash_types to help the migration determine whether it can succeed. > > Thanks. > >> -- >> MST > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/