Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92866C31E40 for ; Tue, 6 Aug 2019 06:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6608F206A2 for ; Tue, 6 Aug 2019 06:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731671AbfHFGb7 (ORCPT ); Tue, 6 Aug 2019 02:31:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3765 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726076AbfHFGb7 (ORCPT ); Tue, 6 Aug 2019 02:31:59 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E3131677EF7A9412FF53; Tue, 6 Aug 2019 14:31:56 +0800 (CST) Received: from [127.0.0.1] (10.184.12.158) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Tue, 6 Aug 2019 14:31:46 +0800 Subject: Re: [PATCH 1/2] KVM: arm64: Don't write junk to sysregs on reset To: Marc Zyngier , , , CC: Andrew Jones , Suzuki K Poulose , James Morse , Julien Thierry References: <20190805121555.130897-1-maz@kernel.org> <20190805121555.130897-2-maz@kernel.org> From: Zenghui Yu Message-ID: <01b74492-c59f-dfd9-e439-752e6b1c53dc@huawei.com> Date: Tue, 6 Aug 2019 14:29:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Thunderbird/64.0 MIME-Version: 1.0 In-Reply-To: <20190805121555.130897-2-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.12.158] X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Marc, On 2019/8/5 20:15, Marc Zyngier wrote: > At the moment, the way we reset system registers is mildly insane: > We write junk to them, call the reset functions, and then check that > we have something else in them. > > The "fun" thing is that this can happen while the guest is running > (PSCI, for example). If anything in KVM has to evaluate the state > of a system register while junk is in there, bad thing may happen. > > Let's stop doing that. Instead, we track that we have called a > reset function for that register, and assume that the reset > function has done something. This requires fixing a couple of > sysreg refinition in the trap table. > > In the end, the very need of this reset check is pretty dubious, > as it doesn't check everything (a lot of the sysregs leave outside of > the sys_regs[] array). It may well be axed in the near future. > > Signed-off-by: Marc Zyngier (Regardless of whether this check is needed or not,) I tested this patch with kvm-unit-tests: for i in {1..100}; do QEMU=/path/to/qemu-system-aarch64 accel=kvm arch=arm64 ./run_tests.sh; done And all the tests passed! Thanks, zenghui