From: "Fish Wang" References: <1450055187-17397-1-git-send-email-fish.thss@...277...> <1450056335-18444-1-git-send-email-fish.thss@...277...> In-Reply-To: Date: Mon, 14 Dec 2015 09:12:39 -0800 Message-ID: <01c501d13692$a42af9a0$ec80ece0$@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_01C6_01D1364F.960855E0" Content-Language: zh-cn Subject: Re: [Openvpn-devel] [PATCH] Make "block-outside-dns" option platform agnostic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Selva Nair' Cc: openvpn-devel@lists.sourceforge.net This is a multipart message in MIME format. ------=_NextPart_000_01C6_01D1364F.960855E0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I see, let me add that file to Makefile.am. My modified build system does n= ot create the dist tarball :-( =20 Best, Fish =20 From: Selva Nair [mailto:selva.nair@...277...]=20 Sent: Monday, December 14, 2015 9:01 AM To: Fish Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [PATCH] Make "block-outside-dns" option platform agnostic =20 Hi, On Sun, Dec 13, 2015 at 8:25 PM, Fish > wrote: Make the "block-outside-dns" option agnostic of Windows versions by dynamic= ally loading WFP-related functions. Cross-compiled on Linux and tested on Windows XP/10. --- src/openvpn/Makefile.am | 2 +- src/openvpn/init.c | 4 - src/openvpn/options.c | 17 ++- src/openvpn/win32.c | 114 ++++++++------- src/openvpn/win32.h | 1 + src/openvpn/win32_wfp.h | 359 ++++++++++++++++++++++++++++++++++++++++++++= ++++ =20 Looks good, including the attribution to the right mingw upstream.. But won't build, as the new header (win32_wfp.h) is not added to=20 src/openvpn/Makefile.am --- without that it wont get into the=20 dist tarball etc.. Next time please append a version number to the mail header:=20 something like [PATCH v2] would do. I'm getting confused with=20 too many versions :) =20 Thanks, Selva =20 =20 ------=_NextPart_000_01C6_01D1364F.960855E0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

I see, let me add that file to Makefile.am. My modified build system does= not create the dist tarball :-(

=

Best,

Fish

&nbs= p;

From: Selva= Nair [mailto:selva.nair@...277...]
Sent: Monday, December 14, 2= 015 9:01 AM
To: Fish <fish.thss@...277...>
Cc: op= envpn-devel@lists.sourceforge.net
Subject: Re: [PATCH] Make "= ;block-outside-dns" option platform agnostic

<= p class=3DMsoNormal style=3D'margin-bottom:12.0pt'>Hi,

On Sun, Dec 13, 2015 at 8:25 PM, Fish <fish.thss@...277...> wrote:

Make the "block-outside-dns" option agnost= ic of Windows versions by dynamically
loading WFP-related functions. Cro= ss-compiled on Linux and tested on Windows
XP/10.
---
src/op= envpn/Makefile.am | 2 +-
src/openvpn/init.c &nbs= p; | 4 -
src/openvpn/options.c |&nb= sp; 17 ++-
src/openvpn/win32.c | 114 ++++++++--= -----
src/openvpn/win32.h | 1 +
= src/openvpn/win32_wfp.h | 359 +++++++++++++++++++++++++++++++++++++++= +++++++++

Looks good, including the= attribution to the right mingw upstream..

=

But won't build, as the new header = (win32_wfp.h) is not added to
src/openvpn/Makefile.am --- without that = it wont get into the
dist tarball etc..

Next time please append = a version number to the mail header:
something like [PATCH v2] would do= . I'm getting confused with
too many versions :)

<= /div>

<= /p>

Thanks,

Selva

<= span lang=3DEN-US>

= = ------=_NextPart_000_01C6_01D1364F.960855E0--