From: "ordex (Code Review)"
Date: Wed, 25 Sep 2024 11:56:39 +0000
In-Reply-To:
References:
Reply-To: a@...2181..., arne-openvpn@...1227..., gianmarco@...2726...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296...
Message-ID: <01ef65e99a7ced9ebc423eaa97d69c5eb576c876-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="DLmWjvHlIOo="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute: properly
print protocol at the end of the string
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: cron2 , plaisthos , flichtenheld , openvpn-devel
--DLmWjvHlIOo=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, its_Giaan, plais=
thos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/765?usp=3Demail )
Change subject: mroute: properly print protocol at the end of the string
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This definitely needs a commit message with a better Subject line (first =
line) - now git whill show [=E2=80=A6]
I think here there was some fixup/squash mess.
Commit message definitely needs some love <3.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab
Gerrit-Change-Number: 765
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 25 Sep 2024 11:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--DLmWjvHlIOo=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, its_Giaan, p=
laisthos.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">Patchset:
Patch Set #1:
This definitely needs =
a commit message with a better Subject line (first line) - now git whill sh=
ow [=E2=80=A6]
I think here there was some fixup/squash mess.
Commit me=
ssage definitely needs some love <3.
To view, =
visit cha=
nge 765. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca=
88728068a92ab
Gerrit-Change-Number: 765
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: its_Giaan <gianmarco@...1665...=
726...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 25 Sep 2024 11:56:39=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--DLmWjvHlIOo=--