Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=219.87.191.90; helo=mx01.quantatw.com; envelope-from=prvs=141476095=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx01.quantatw.com (mx01.quantatw.com [219.87.191.90]) by lists.ozlabs.org (Postfix) with ESMTP id 46MP4B2RX2zDqBd for ; Mon, 2 Sep 2019 18:52:49 +1000 (AEST) Received: from unknown (HELO mailbx05.quanta.corp) ([10.243.91.100]) by mx01.quantatw.com with ESMTP; 02 Sep 2019 16:52:46 +0800 Received: from mailbx09.quanta.corp (10.243.91.106) by mailbx05.quanta.corp (10.243.91.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 2 Sep 2019 16:52:45 +0800 Received: from mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81]) by mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81%6]) with mapi id 15.01.1713.004; Mon, 2 Sep 2019 16:52:45 +0800 From: =?big5?B?SGFuayBMaW91ICi8Qq7Kv6sp?= To: Patrick Venture CC: James Feist , "openbmc@lists.ozlabs.org" Subject: Re: [phosphor-pid-control] scaling issue Thread-Topic: [phosphor-pid-control] scaling issue Thread-Index: AQHVV/XbtwEoqXVk+kGbiKtv2uj0UqcFJGgAgAE9VwCAC0qVsIAAQT+AgAYx+Nc= Date: Mon, 2 Sep 2019 08:52:45 +0000 Message-ID: <02128993d3064b53ac289500746666ab@quantatw.com> References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> , In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] Content-Type: multipart/alternative; boundary="_000_02128993d3064b53ac289500746666abquantatwcom_" MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2019 08:53:00 -0000 --_000_02128993d3064b53ac289500746666abquantatwcom_ Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: base64 SGkgUGF0cmljaywNCg0KDQpTaW5jZSB3ZSB1c2UgcGhvc3Bob3Itc2VsLWxvZ2dlciBbMV0gYXQg dGhlIHNhbWUgdGltZSwgd2UgZG8gYXNzaWduIG1pbiBhbmQgbWF4IG9mIHRlbXAgc2Vuc29ycyB0 byBEYnVzIChtYXg6IDEyNywgbWluOiAtMTI4KS4gU28gaW4gdGhlIHByZXNlbnQgY2FzZSwgb3Vy IHRlbXAgdmFsdWUgd2lsbCBiZSBkaXZpZGVkIGJ5IDAuMjU1IChhbHNvIGR1ZSB0byBleHBvbmVu dCBpcyAtMyBoZXJlKS4gVGhpcyB3aWxsIGNhdXNlIHJlLXNjYWxpbmcgcHJvYmxlbS4gVGhlcmVm b3JlIHRoZXJlIHNob3VsZCBiZSBhbiBzdGF0ZW1lbnQgdG8gZGlzdGluZ3Vpc2ggc2Vuc29yIHR5 cGVzLiBJZiBpdCBpcyAidGVtcCIsIHRoZW4gb25lIGFzc2lnbnMgMCB0byB0aGUgbWluIGFuZCBt YXggZnJvbSBEYnVzLg0KDQoNClsxXSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhv ci1zZWwtbG9nZ2VyL2Jsb2IvM2QzMDBmY2EyNGIzMDg2NGIzZTlhNGY1NzY4Y2ZlNWU3Njk0NThh ZS9pbmNsdWRlL3NlbnNvcnV0aWxzLmhwcCNMNTk8aHR0cHM6Ly9nPg0KDQoNCkhhbmsNCg0KDQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KRnJvbTogUGF0cmljayBWZW50dXJlIDx2 ZW50dXJlQGdvb2dsZS5jb20+DQpTZW50OiBGcmlkYXksIEF1Z3VzdCAzMCwgMjAxOSAxOjQ3IEFN DQpUbzogSGFuayBMaW91ICi8Qq7Kv6spDQpDYzogSmFtZXMgRmVpc3Q7IG9wZW5ibWNAbGlzdHMu b3psYWJzLm9yZw0KU3ViamVjdDogUmU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGluZyBp c3N1ZQ0KDQpQVEFMIC0gaHR0cHM6Ly9nZXJyaXQub3BlbmJtYy1wcm9qZWN0Lnh5ei8yNDgyNyAt IHRoaXMgaXMgbWVyZ2VkLCBhbmQNCnRoZSBzcmNyZXYgYnVtcCBzaG91bGQgcHJvcGFnYXRlIGlu dG8gb3BlbmJtYy9vcGVuYm1jIGluIGEgZGF5IG9yIHR3by4NCg0KT24gV2VkLCBBdWcgMjgsIDIw MTkgYXQgMTE6MDAgUE0gSGFuayBMaW91ICi8Qq7Kv6spIDxIYW5rLkxpb3VAcXVhbnRhdHcuY29t PiB3cm90ZToNCj4NCj4gSGkgUGF0cmljaywNCj4NCj4gSSB0aGluayBpdCdzIE9LIHRvIHBhcnNl IHRoZSBjb25maWcgbWluJm1heCBmb3IgdGVtcCBzZW5zb3JzLg0KPg0KPiBBbnkgc3VnZ2VzdGlv bj8NCj4NCj4gVGhhbmtzLA0KPiBIYW5rDQo+DQo+ID4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiA+RnJvbTogb3BlbmJtYyBbbWFpbHRvOm9wZW5ibWMtDQo+ID5ib3VuY2VzK2hhbmsubGlv dT1xdWFudGF0dy5jb21AbGlzdHMub3psYWJzLm9yZ10gT24gQmVoYWxmIE9mIEhhbmsgTGlvdQ0K PiA+KLxCrsq/qykNCj4gPlNlbnQ6IEZyaWRheSwgQXVndXN0IDIzLCAyMDE5IDQ6MzEgUE0NCj4g PlRvOiBQYXRyaWNrIFZlbnR1cmUgPHZlbnR1cmVAZ29vZ2xlLmNvbT47IEphbWVzIEZlaXN0DQo+ ID48amFtZXMuZmVpc3RAbGludXguaW50ZWwuY29tPg0KPiA+Q2M6IG9wZW5ibWNAbGlzdHMub3ps YWJzLm9yZw0KPiA+U3ViamVjdDogUkU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGluZyBp c3N1ZQ0KPiA+DQo+ID5IaSBQYXRyaWNrLA0KPiA+DQo+ID4+LS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4gPj5Gcm9tOiBQYXRyaWNrIFZlbnR1cmUgW21haWx0bzp2ZW50dXJlQGdvb2dsZS5j b21dDQo+ID4+U2VudDogV2VkbmVzZGF5LCBBdWd1c3QgMjEsIDIwMTkgMTA6MzIgUE0NCj4gPj5U bzogSGFuayBMaW91ICi8Qq7Kv6spIDxIYW5rLkxpb3VAcXVhbnRhdHcuY29tPjsgSmFtZXMgRmVp c3QNCj4gPj48amFtZXMuZmVpc3RAbGludXguaW50ZWwuY29tPg0KPiA+PkNjOiBvcGVuYm1jQGxp c3RzLm96bGFicy5vcmcNCj4gPj5TdWJqZWN0OiBSZTogW3Bob3NwaG9yLXBpZC1jb250cm9sXSBz Y2FsaW5nIGlzc3VlDQo+ID4+DQo+ID4+T24gV2VkLCBBdWcgMjEsIDIwMTkgYXQgMToxMSBBTSBI YW5rIExpb3UgKLxCrsq/qykNCj4gPj48SGFuay5MaW91QHF1YW50YXR3LmNvbT4gd3JvdGU6DQo+ ID4+Pg0KPiA+Pj4gSGkgQWxsLA0KPiA+Pj4NCj4gPj4+DQo+ID4+PiBBZnRlciBjb21taXQgWzFd LCBJIGZvdW5kIG15IHRlbXAgc2Vuc29yIHJlYWRpbmcgd291bGQgYmUgcmUtc2NhbGVkDQo+ID4+ PiBieQ0KPiA+Pm11bHRpcGx5aW5nIDEgb3ZlciAyNTUsIG1ha2luZyB0ZW1wZXJhdHVyZSBpbnRv IHVuZmFtaWxpYXIgdW5pdC4gQWxzbw0KPiA+PnRoZSBmYW4gcnBtIHJlYWRpbmcgd291bGQgbGll IGluIFswLDFdIGludGVydmFsLCBsZXR0aW5nIHRoZSBmYW4gaW5wdXQNCj4gPj50byBiZSAwIChz aW5jZSB0aGUgaW5wdXQgdmFsdWUgb2YgZmFuIGlzIGZyb20gYW4gaW50ZWdlciBhcnJheSBbMl0p LiBBcmUgdGhlc2UNCj4gPm5vcm1hbCBiZWhhdmlvcnM/DQo+ID4+T3IgZG8gSSBtaXNzIHNvbWV0 aGluZz8NCj4gPj4NCj4gPj5BcmUgeW91IHVzaW5nIGRidXMgY29uZmlndXJhdGlvbiBvciBqc29u PyAgSWYganNvbiwgY2FuIHlvdSBhdHRhY2ggeW91ciBjb25maWcuDQo+ID4+U2luY2UgeW91J3Jl IHNheWluZyBpdCB3YXMgd29ya2luZyBhbmQgbm93IGlzbid0LCBJJ20gYXNzdW1pbmcgdGhlcmUn cw0KPiA+PnNvbWV0aGluZyBhYm91dCB0aGUgY29uZmlnIGJlaW5nIHRyZWF0ZWQgZGlmZmVyZW50 bHkgd2l0aCB0aGUgY29kZQ0KPiA+PmNoYW5nZXMgaW4gYW4gdW5leHBlY3RlZCB3YXkuDQo+ID4N Cj4gPkkgZm91bmQgcGlkIGNvbnRyb2wgd2lsbCBmaXJzdCByZWFkIG1pbiBhbmQgbWF4IGZyb20g ZGJ1cyBhbmQgdGhlbiAoYmVmb3JlDQo+ID5jb21taXQgWzFdKSByZXZpc2UgdGhlbSBpZg0KPiA+ DQo+ID5pbmZvLT5taW4gIT0gY29uZjo6aW5oZXJpdFZhbHVlRnJvbURidXMgKGluIGRidXMvZGJ1 c3Bhc3NpdmUuY3BwKQ0KPiA+DQo+ID5BZnRlciB2YWx1ZSBpbml0aWFsaXphdGlvbiwgdGhlIG1p biBhbmQgbWF4IHdvdWxkIGJlIHRoZSBvbmVzIGluIGpzb24gZmlsZSAoSnNvbg0KPiA+ZmlsZSBb M10pLiBIb3dldmVyLCBhZnRlciBjb21taXQgWzFdIHRoZSBtaW4gYW5kIG1heCB2YWx1ZXMgb2Yg Y29uZmlnIHdvdWxkDQo+ID5ub3QgYmUgZmVkIGludG8gdGhlIGZhbiBjb250cm9sIHByb2Nlc3Mu IFRoZSBzY2FsaW5nIGlzc3VlIGlzIG9yaWdpbmF0ZWQgZnJvbQ0KPiA+Y29tbWl0IFs0XSB3aXRo IHRoZSBhaW0gdG8gdHJlYXQgZmFuIHJwbSBhcyBwZXJjZW50YWdlLiBJdCBzZWVtcyB0aGF0IGNv bW1pdA0KPiA+WzFdIHVuZXhwZWN0ZWRseSBhZmZlY3RzIHRlbXAgc2Vuc29ycyBpbiB0aGUgc2Vu c2UgdGhhdCB0aGUgdGVtcCBpcyB0aGUNCj4gPmludGVnZXIgcmVhZGluZyBub3QgcGVyY2VudGFn ZS4gQmVmb3JlIGNvbW1pdCBbMV0sIGl0IHdvdWxkIG5vdCByZS1zY2FsZSB0aGUNCj4gPnRlbXAg cmVhZGluZyBzaW5jZSBteSBtaW4gYW5kIG1heCBhcmUgMCBbNl0uDQo+ID4NCj4gPg0KPiA+DQo+ ID5UaGVyZSBpcyBhbm90aGVyIGlzc3VlIHdpdGggY29tbWl0IFsxXS4gTm93IHRoZSBmYW4gcnBt IHdvdWxkIGJlIHNvbWV0aGluZw0KPiA+bGlrZQ0KPiA+DQo+ID4xNTAwIC8gMjAwMDAgPSAwLjA3 NQ0KPiA+DQo+ID53aGVyZSBycG0gbWF4IDIwMDAwIGlzIGZyb20gZGJ1cy4gSG93ZXZlciB0aGUg ZmFuIGlucHV0IGZ1bmN0aW9uIHdvdWxkDQo+ID50cmFuc2ZlciBkb3VibGUgaW50byBpbnQsIHdo aWNoIGlzIDAgZm9yIDAuMDc1IChzZWUgWzVdKS4gSGVuY2UgdGhlIGZhbiBpbnB1dCBpcyAwDQo+ ID5ub3QgcGVyY2VudGFnZS4gSXMgdGhlcmUgc29tZXRoaW5nIHdyb25nPw0KPiA+DQo+ID5bMV0g aHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPiA+Y29udHJvbC9jb21t aXQvZmMyZTgwM2Y1ZDkyNTY5NDRlMThjN2M4NzhhNDQxNjA2YjFmMTIxYw0KPiA+WzJdIGh0dHBz Oi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBpZC0NCj4gPmNvbnRyb2wvYmxvYi9hN2Vj ODM1MGQxN2I3MDE1M2NlYmU2NjZkM2ZiZTg4YmRkZDAyYTFhL3BpZC9mYW5jb250cm9sbGUNCj4g PnIuY3BwI0w4Ng0KPiA+WzNdDQo+ID4gICAgICAgew0KPiA+ICAgICAgICAgICAgIm5hbWUiOiAi ZmFuMSIsDQo+ID4gICAgICAgICAgICAidHlwZSI6ICJmYW4iLA0KPiA+ICAgICAgICAgICAgInJl YWRQYXRoIjogIi9zeXMvY2xhc3MvaHdtb24vaHdtb24xL2ZhbjFfaW5wdXQiLA0KPiA+ICAgICAg ICAgICAgIndyaXRlUGF0aCI6ICIvc3lzL2NsYXNzL2h3bW9uL2h3bW9uMS9wd20xIiwNCj4gPiAg ICAgICAgICAgICJtaW4iOiAwLA0KPiA+ICAgICAgICAgICAgIm1heCI6IDI1NQ0KPiA+ICAgICAg ICB9LA0KPiA+ICAgICAgICB7DQo+ID4gICAgICAgICAgICAibmFtZSI6ICJ0ZW1wMSIsDQo+ID4g ICAgICAgICAgICAidHlwZSI6ICJ0ZW1wIiwNCj4gPiAgICAgICAgICAgICJyZWFkUGF0aCI6ICIv eHl6L29wZW5ibWNfcHJvamVjdC9zZW5zb3JzL3RlbXBlcmF0dXJlL3RlbXAxIiwNCj4gPiAgICAg ICAgICAgICJ3cml0ZVBhdGgiOiAiIiwNCj4gPiAgICAgICAgICAgICJtaW4iOiAwLA0KPiA+ICAg ICAgICAgICAgIm1heCI6IDANCj4gPiAgICAgICAgfQ0KPiA+WzRdIGh0dHBzOi8vZ2l0aHViLmNv bS9vcGVuYm1jL3Bob3NwaG9yLXBpZC0NCj4gPmNvbnRyb2wvY29tbWl0Lzc1ZWI3NjlkMzUxNDM0 NTQ3ODk5MTg2ZjczZmY3MGFlMDBkNzkzNGENCj4gPls1XSBodHRwczovL2dpdGh1Yi5jb20vb3Bl bmJtYy9waG9zcGhvci1waWQtDQo+ID5jb250cm9sL2Jsb2IvYTdlYzgzNTBkMTdiNzAxNTNjZWJl NjY2ZDNmYmU4OGJkZGQwMmExYS9waWQvZmFuY29udHJvbGxlDQo+ID5yLmNwcCNMNjQNCj4gPls2 XSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1waWQtDQo+ID5jb250cm9sL2Js b2IvYTdlYzgzNTBkMTdiNzAxNTNjZWJlNjY2ZDNmYmU4OGJkZGQwMmExYS9kYnVzL2RidXNwYXNz aQ0KPiA+dmUuY3BwI0wxNTgNCj4gPg0KPiA+Pg0KPiA+Pj4NCj4gPj4+DQo+ID4+PiBbMV0NCj4g Pj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBpZC0NCj4gPj5jb250cm9s L2NvbW1pdC9mYzJlODAzZjVkOTI1NjkNCj4gPj4+IDQ0ZTE4YzdjODc4YTQ0MTYwNmIxZjEyMWMN Cj4gPj4+DQo+ID4+PiBbMl0NCj4gPj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3Nw aG9yLXBpZC0NCj4gPj5jb250cm9sL2Jsb2IvYTdlYzgzNTBkMTdiNzAxNTMNCj4gPj4+IGNlYmU2 NjZkM2ZiZTg4YmRkZDAyYTFhL3BpZC9mYW5jb250cm9sbGVyLmNwcCNMODYNCj4gPj4+DQo+ID4+ Pg0KPiA+Pj4gVGhhbmtzLA0KPiA+Pj4NCj4gPj4+DQo+ID4+PiBIYW5rIExpb3UNCj4gPj4+DQo+ ID4+PiBRdWFudGEgQ29tcHV0ZXIgSW5jLg0KPiA+Pj4NCj4gPj4+DQo+ID4NCj4gPlNpbmNlcmVs eSwNCj4gPkhhbmsNCg== --_000_02128993d3064b53ac289500746666abquantatwcom_ Content-Type: text/html; charset="big5" Content-Transfer-Encoding: quoted-printable

Hi Patrick,


Since we use phosphor-sel-logger [1] at the same time, we do assign= min and max of temp sensors to Dbus (max: 127, min: -128). So i<= span style=3D"font-family: Calibri, Helvetica, sans-serif, EmojiFont, "= ;Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "= ;Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size:= 16px;">n the present case, our temp value will be divided by 0.255 (also due to&nbs= p;exponent is -3 here). This will cause re-scaling proble= m. Therefore there should be an statement to distinguish sensor types. If it is &qu= ot;temp", then one assigns 0 to the min and max from Dbus.=


[1] https://github.= com/openbmc/phosphor-sel-logger/blob/3d300fca24b30864b3e9a4f5768cfe5e769458= ae/include/sensorutils.hpp#L59


Hank



From: Patrick Venture <= ;venture@google.com>
Sent: Friday, August 30, 2019 1:47 AM
To: Hank Liou (=BCB=AE=CA=BF=AB)
Cc: James Feist; openbmc@lists.ozlabs.org
Subject: Re: [phosphor-pid-control] scaling issue
 
PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, and
the srcrev bump should propagate into openbmc/openbmc in a day or two.

On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=BCB=AE=CA=BF=AB) <Hank.Liou= @quantatw.com> wrote:
>
> Hi Patrick,
>
> I think it's OK to parse the config min&max for temp sensors.
>
> Any suggestion?
>
> Thanks,
> Hank
>
> >-----Original Message-----
> >From: openbmc [mailto:openbmc-
> >bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf O= f Hank Liou
> >(=BCB=AE=CA=BF=AB)
> >Sent: Friday, August 23, 2019 4:31 PM
> >To: Patrick Venture <venture@google.com>; James Feist
> ><james.feist@linux.intel.com>
> >Cc: openbmc@lists.ozlabs.org
> >Subject: RE: [phosphor-pid-control] scaling issue
> >
> >Hi Patrick,
> >
> >>-----Original Message-----
> >>From: Patrick Venture [m= ailto:venture@google.com]
> >>Sent: Wednesday, August 21, 2019 10:32 PM
> >>To: Hank Liou (=BCB=AE=CA=BF=AB) <Hank.Liou@quantatw.com>= ;; James Feist
> >><james.feist@linux.intel.com>
> >>Cc: openbmc@lists.ozlabs.org
> >>Subject: Re: [phosphor-pid-control] scaling issue
> >>
> >>On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=BCB=AE=CA=BF=AB) > >><Hank.Liou@quantatw.com> wrote:
> >>>
> >>> Hi All,
> >>>
> >>>
> >>> After commit [1], I found my temp sensor reading would be= re-scaled
> >>> by
> >>multiplying 1 over 255, making temperature into unfamiliar uni= t. Also
> >>the fan rpm reading would lie in [0,1] interval, letting the f= an input
> >>to be 0 (since the input value of fan is from an integer array= [2]). Are these
> >normal behaviors?
> >>Or do I miss something?
> >>
> >>Are you using dbus configuration or json?  If json, can y= ou attach your config.
> >>Since you're saying it was working and now isn't, I'm assuming= there's
> >>something about the config being treated differently with the = code
> >>changes in an unexpected way.
> >
> >I found pid control will first read min and max from dbus and then= (before
> >commit [1]) revise them if
> >
> >info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.= cpp)
> >
> >After value initialization, the min and max would be the ones in j= son file (Json
> >file [3]). However, after commit [1] the min and max values of con= fig would
> >not be fed into the fan control process. The scaling issue is orig= inated from
> >commit [4] with the aim to treat fan rpm as percentage. It seems t= hat commit
> >[1] unexpectedly affects temp sensors in the sense that the temp i= s the
> >integer reading not percentage. Before commit [1], it would not re= -scale the
> >temp reading since my min and max are 0 [6].
> >
> >
> >
> >There is another issue with commit [1]. Now the fan rpm would be s= omething
> >like
> >
> >1500 / 20000 =3D 0.075
> >
> >where rpm max 20000 is from dbus. However the fan input function w= ould
> >transfer double into int, which is 0 for 0.075 (see [5]). Hence th= e fan input is 0
> >not percentage. Is there something wrong?
> >
> >[1] https://g= ithub.com/openbmc/phosphor-pid-
> >control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c
> >[2] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontr= olle
> >r.cpp#L86
> >[3]
> >       {
> >           = "name": "fan1",
> >           = "type": "fan",
> >           = "readPath": "/sys/class/hwmon/hwmon1/fan1_input",
> >           = "writePath": "/sys/class/hwmon/hwmon1/pwm1",
> >           = "min": 0,
> >           = "max": 255
> >        },
> >        {
> >           = "name": "temp1",
> >           = "type": "temp",
> >           = "readPath": "/xyz/openbmc_project/sensors/temperature/temp1= ",
> >           = "writePath": "",
> >           = "min": 0,
> >           = "max": 0
> >        }
> >[4] https://g= ithub.com/openbmc/phosphor-pid-
> >control/commit/75eb769d351434547899186f73ff70ae00d7934a
> >[5] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontr= olle
> >r.cpp#L64
> >[6] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspas= si
> >ve.cpp#L158
> >
> >>
> >>>
> >>>
> >>> [1]
> >>> http= s://github.com/openbmc/phosphor-pid-
> >>control/commit/fc2e803f5d92569
> >>> 44e18c7c878a441606b1f121c
> >>>
> >>> [2]
> >>> http= s://github.com/openbmc/phosphor-pid-
> >>control/blob/a7ec8350d17b70153
> >>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86
> >>>
> >>>
> >>> Thanks,
> >>>
> >>>
> >>> Hank Liou
> >>>
> >>> Quanta Computer Inc.
> >>>
> >>>
> >
> >Sincerely,
> >Hank
--_000_02128993d3064b53ac289500746666abquantatwcom_--