From: Andrey Grodzovsky Subject: Re: [PATCH v3 1/6] drm/amd/display: Use DRM new-style object iterators. Date: Fri, 13 Oct 2017 16:36:53 -0400 Message-ID: <02155b03-81e9-32d1-b06d-b6050882596d@amd.com> References: <1507842911-16975-2-git-send-email-sunpeng.li@amd.com> <1507922970-22877-1-git-send-email-sunpeng.li@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1507922970-22877-1-git-send-email-sunpeng.li@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: sunpeng.li@amd.com, airlied@gmail.com, amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org CgpPbiAxMC8xMy8yMDE3IDAzOjI5IFBNLCBzdW5wZW5nLmxpQGFtZC5jb20gd3JvdGU6Cj4gRnJv bTogIkxlbyAoU3VucGVuZykgTGkiIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4KPiBVc2UgdGhlIGNv cnJlY3QgZm9yX2VhY2hfbmV3L29sZF8qIGl0ZXJhdG9ycyBpbnN0ZWFkIG9mIGZvcl9lYWNoXyoK Pgo+IFRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIHdlcmUgY29uc2lkZXJlZDoKPgo+IGFtZGdwdV9k bV9maW5kX2ZpcnN0X2NydGNfbWF0Y2hpbmdfY29ubmVjdG9yOiB1c2UgZm9yX2VhY2hfbmV3Cj4g ICAgICAtIE9sZCBmcm9tX3N0YXRlX3ZhciBmbGFnIHdhcyBhbHdheXMgY2hvb3NpbmcgdGhlIG5l dyBzdGF0ZQo+Cj4gYW1kZ3B1X2RtX2Rpc3BsYXlfcmVzdW1lOiB1c2UgZm9yX2VhY2hfbmV3Cj4g ICAgICAtIGRybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0ZSBpcyBjYWxsZWQgZHVyaW5n IHN1c3BlbmQgdG8KPiAgICAgICAgY2FjaGUgdGhlIHN0YXRlCj4gICAgICAtIEl0IHNldHMgJ3N0 YXRlJyB3aXRoaW4gdGhlIHN0YXRlIHRyaXBsZXQgdG8gJ25ld19zdGF0ZScKPgo+IGFtZGdwdV9k bV9jb21taXRfcGxhbmVzOiB1c2UgZm9yX2VhY2hfb2xkCj4gICAgICAtIENhbGxlZCBhZnRlciB0 aGUgc3RhdGUgd2FzIHN3YXBwZWQgKHZpYSBhdG9taWMgY29tbWl0IHRhaWwpCj4KPiBhbWRncHVf ZG1fYXRvbWljX2NvbW1pdDogdXNlIGZvcl9lYWNoX25ldwo+ICAgICAgLSBDYWxsZWQgYmVmb3Jl IHRoZSBzdGF0ZSBpcyBzd2FwcGVkCj4KPiBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsOiB1 c2UgZm9yX2VhY2hfb2xkCj4gICAgICAtIENhbGxlZCBhZnRlciB0aGUgc3RhdGUgd2FzIHN3YXBw ZWQKPgo+IGRtX3VwZGF0ZV9jcnRjc19zdGF0ZTogdXNlIGZvcl9lYWNoX25ldwo+ICAgICAgLSBD YWxsZWQgYmVmb3JlIHRoZSBzdGF0ZSBpcyBzd2FwcGVkICh2aWEgYXRvbWljIGNoZWNrKQo+Cj4g YW1kZ3B1X2RtX2F0b21pY19jaGVjazogdXNlIGZvcl9lYWNoX25ldwo+ICAgICAgLSBDYWxsZWQg YmVmb3JlIHRoZSBzdGF0ZSBpcyBzd2FwcGVkCj4KPiB2MjogU3BsaXQgb3V0IHR5cG8gZml4ZXMg dG8gYSBuZXcgcGF0Y2guCj4KPiB2MzogU2F5ICJmdW5jdGlvbnMgY29uc2lkZXJlZCIgaW5zdGVh ZCBvZiAiYWZmZWN0ZWQgZnVuY3Rpb25zIi4gVGhlCj4gICAgICBsYXR0ZXIgaW1wbGllcyB0aGF0 IGNoYW5nZXMgYXJlIG1hZGUgdG8gZWFjaC4KPgo+IFNpZ25lZC1vZmYtYnk6IExlbyAoU3VucGVu ZykgTGkgPHN1bnBlbmcubGlAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQv ZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMgfCAzMiArKysrKysrKy0tLS0tLS0tLS0tLS0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uaCB8 ICAzICstLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1 X2RtL2FtZGdwdV9kbS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9h bWRncHVfZG0uYwo+IGluZGV4IDliZmUxZjkuLmNjMDI0YWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiBAQCAtNTcwLDIz ICs1NzAsMTUgQEAgc3RhdGljIGludCBkbV9zdXNwZW5kKHZvaWQgKmhhbmRsZSkKPiAgIAo+ICAg c3RydWN0IGFtZGdwdV9kbV9jb25uZWN0b3IgKmFtZGdwdV9kbV9maW5kX2ZpcnN0X2NyY3RfbWF0 Y2hpbmdfY29ubmVjdG9yKAo+ICAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAt CXN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCWJvb2wgZnJvbV9zdGF0ZV92YXIpCj4gKwlzdHJ1 Y3QgZHJtX2NydGMgKmNydGMpCj4gICB7Cj4gICAJdWludDMyX3QgaTsKPiAgIAlzdHJ1Y3QgZHJt X2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiAgIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yOwo+ICAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0Y19mcm9tX3N0YXRlOwo+ICAgCj4g LQlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKAo+IC0JCXN0YXRlLAo+IC0JCWNvbm5l Y3RvciwKPiAtCQljb25uX3N0YXRlLAo+IC0JCWkpIHsKPiAtCQljcnRjX2Zyb21fc3RhdGUgPQo+ IC0JCQlmcm9tX3N0YXRlX3ZhciA/Cj4gLQkJCQljb25uX3N0YXRlLT5jcnRjIDoKPiAtCQkJCWNv bm5lY3Rvci0+c3RhdGUtPmNydGM7Cj4gKwlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRl KHN0YXRlLCBjb25uZWN0b3IsIGNvbm5fc3RhdGUsIGkpIHsKPiArCQljcnRjX2Zyb21fc3RhdGUg PSBjb25uX3N0YXRlLT5jcnRjOwo+ICAgCj4gICAJCWlmIChjcnRjX2Zyb21fc3RhdGUgPT0gY3J0 YykKPiAgIAkJCXJldHVybiB0b19hbWRncHVfZG1fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gQEAg LTM4OTAsNyArMzg4Miw3IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9kbV9jb21taXRfcGxhbmVzKHN0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ ICAgCj4gICAJLyogdXBkYXRlIHBsYW5lcyB3aGVuIG5lZWRlZCAqLwo+IC0JZm9yX2VhY2hfbmV3 X3BsYW5lX2luX3N0YXRlKHN0YXRlLCBwbGFuZSwgb2xkX3BsYW5lX3N0YXRlLCBpKSB7Cj4gKwlm b3JfZWFjaF9vbGRfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBvbGRfcGxhbmVfc3RhdGUs IGkpIHsKPiAgIAkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPSBwbGFuZS0+ c3RhdGU7Cj4gICAJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IHBsYW5lX3N0YXRlLT5jcnRjOwo+ ICAgCQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5mYjsKPiBAQCAt NDAyNCw3ICs0MDE2LDcgQEAgdm9pZCBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsKAo+ICAg CWRtX3N0YXRlID0gdG9fZG1fYXRvbWljX3N0YXRlKHN0YXRlKTsKPiAgIAo+ICAgCS8qIHVwZGF0 ZSBjaGFuZ2VkIGl0ZW1zICovCj4gLQlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShzdGF0ZSwg Y3J0Yywgb2xkX2NydGNfc3RhdGUsIGkpIHsKPiArCWZvcl9lYWNoX29sZF9jcnRjX2luX3N0YXRl KHN0YXRlLCBjcnRjLCBvbGRfY3J0Y19zdGF0ZSwgaSkgewoKQmV0dGVyIGp1c3QgdXNlIGZvcl9l YWNoX25ld19vbGQgaGVyZSwgc28geW91IGNhbiBnZXQgYm90aCBvbGQgYW5kIG5ldyAKZnJvbSB0 aGUgaXRlcmF0b3IuCgo+ICAgCQlzdHJ1Y3QgYW1kZ3B1X2NydGMgKmFjcnRjID0gdG9fYW1kZ3B1 X2NydGMoY3J0Yyk7Cj4gICAJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqbmV3X3N0YXRlID0gY3J0 Yy0+c3RhdGU7Cj4gICAKPiBAQCAtNDExMywxMSArNDEwNSw5IEBAIHZvaWQgYW1kZ3B1X2RtX2F0 b21pY19jb21taXRfdGFpbCgKPiAgIAkJCW5ld19hY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3Rh dGUobmV3X2NydGNzW2ldLT5iYXNlLnN0YXRlKTsKPiAgIAo+ICAgCQkJbmV3X3N0cmVhbSA9IG5l d19hY3J0Y19zdGF0ZS0+c3RyZWFtOwo+IC0JCQlhY29ubmVjdG9yID0KPiAtCQkJCWFtZGdwdV9k bV9maW5kX2ZpcnN0X2NyY3RfbWF0Y2hpbmdfY29ubmVjdG9yKAo+ICsJCQlhY29ubmVjdG9yID0g YW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3JjdF9tYXRjaGluZ19jb25uZWN0b3IoCj4gICAJCQkJCXN0 YXRlLAo+IC0JCQkJCSZuZXdfY3J0Y3NbaV0tPmJhc2UsCj4gLQkJCQkJZmFsc2UpOwo+ICsJCQkJ CSZuZXdfY3J0Y3NbaV0tPmJhc2UpOwo+ICAgCQkJaWYgKCFhY29ubmVjdG9yKSB7Cj4gICAJCQkJ RFJNX0RFQlVHX0RSSVZFUigiQXRvbWljIGNvbW1pdDogRmFpbGVkIHRvIGZpbmQgY29ubmVjdG9y IGZvciBhY3J0YyBpZDolZCAiCj4gICAJCQkJCSAic2tpcHBpbmcgZnJlZXN5bmMgaW5pdFxuIiwK PiBAQCAtNDE1MSw3ICs0MTQxLDcgQEAgdm9pZCBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWls KAo+ICAgCX0KPiAgIAo+ICAgCS8qIEhhbmRsZSBzY2FsaW5nIGFuZCB1bmRlcnNhY24gY2hhbmdl cyovCj4gLQlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3Is IG9sZF9jb25uX3N0YXRlLCBpKSB7Cj4gKwlmb3JfZWFjaF9vbGRfY29ubmVjdG9yX2luX3N0YXRl KHN0YXRlLCBjb25uZWN0b3IsIG9sZF9jb25uX3N0YXRlLCBpKSB7Cj4gICAJCXN0cnVjdCBhbWRn cHVfZG1fY29ubmVjdG9yICphY29ubmVjdG9yID0gdG9fYW1kZ3B1X2RtX2Nvbm5lY3Rvcihjb25u ZWN0b3IpOwo+ICAgCQlzdHJ1Y3QgZG1fY29ubmVjdG9yX3N0YXRlICpjb25fbmV3X3N0YXRlID0K PiAgIAkJCQl0b19kbV9jb25uZWN0b3Jfc3RhdGUoYWNvbm5lY3Rvci0+YmFzZS5zdGF0ZSk7Cj4g QEAgLTQyMDUsNyArNDE5NSw3IEBAIHZvaWQgYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbCgK PiAgIAl9Cj4gICAKPiAgIAkvKiB1cGRhdGUgcGxhbmVzIHdoZW4gbmVlZGVkIHBlciBjcnRjKi8K PiAtCWZvcl9lYWNoX25ld19jcnRjX2luX3N0YXRlKHN0YXRlLCBwY3J0Yywgb2xkX2NydGNfc3Rh dGUsIGopIHsKPiArCWZvcl9lYWNoX29sZF9jcnRjX2luX3N0YXRlKHN0YXRlLCBwY3J0Yywgb2xk X2NydGNfc3RhdGUsIGopIHsKPiAgIAkJbmV3X2FjcnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0 ZShwY3J0Yy0+c3RhdGUpOwoKV2h5IGRpZCB5b3Ugc3dpdGNoIHRvIGZvcl9lYWNoX29sZCBpdGVy YXRvciBoZXJlID8gaWYgeW91IHVzZSB0aGUgCmZvcl9lYWNoX25ldwppdGVyYXRvciB5b3UgY2Fu IGdldCByaWQgb2YgbmV3X2FjcnRjX3N0YXRlID0gCnRvX2RtX2NydGNfc3RhdGUocGNydGMtPnN0 YXRlKTsKYW5kIGp1c3QgdXNlIHRoZSBpdGVyYXRvcidzIHN0YXRlCj4gICAKPiAgIAkJaWYgKG5l d19hY3J0Y19zdGF0ZS0+c3RyZWFtKQo+IEBAIC00MjE4LDcgKzQyMDgsNyBAQCB2b2lkIGFtZGdw dV9kbV9hdG9taWNfY29tbWl0X3RhaWwoCj4gICAJICogbWFyayBjb25zdW1lZCBldmVudCBmb3Ig ZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X2h3X2RvbmUKPiAgIAkgKi8KPiAgIAlzcGluX2xvY2tf aXJxc2F2ZSgmYWRldi0+ZGRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+IC0JZm9yX2VhY2hfbmV3 X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRlLCBpKSB7Cj4gKwlmb3Jf ZWFjaF9vbGRfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsIGkpIHsK PiAgIAkJc3RydWN0IGFtZGdwdV9jcnRjICphY3J0YyA9IHRvX2FtZGdwdV9jcnRjKGNydGMpOwoK U2FtZSBhcyBhYm92ZQoKVGhhbmtzLApBbmRyZXkKCj4gICAKPiAgIAkJaWYgKGFjcnRjLT5iYXNl LnN0YXRlLT5ldmVudCkKPiBAQCAtNDQwMiw3ICs0MzkyLDcgQEAgc3RhdGljIGludCBkbV91cGRh dGVfY3J0Y3Nfc3RhdGUoCj4gICAJCW5ld19hY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3RhdGUo Y3J0Y19zdGF0ZSk7Cj4gICAJCWFjcnRjID0gdG9fYW1kZ3B1X2NydGMoY3J0Yyk7Cj4gICAKPiAt CQlhY29ubmVjdG9yID0gYW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3JjdF9tYXRjaGluZ19jb25uZWN0 b3Ioc3RhdGUsIGNydGMsIHRydWUpOwo+ICsJCWFjb25uZWN0b3IgPSBhbWRncHVfZG1fZmluZF9m aXJzdF9jcmN0X21hdGNoaW5nX2Nvbm5lY3RvcihzdGF0ZSwgY3J0Yyk7Cj4gICAKPiAgIAkJLyog VE9ETyBUaGlzIGhhY2sgc2hvdWxkIGdvIGF3YXkgKi8KPiAgIAkJaWYgKGFjb25uZWN0b3IpIHsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRn cHVfZG0uaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2Rt LmgKPiBpbmRleCA2MzBlNmNkLi4xYzU1YTBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5oCj4gQEAgLTIyOCw4ICsyMjgsNyBA QCB2b2lkIGFtZGdwdV9kbV91cGRhdGVfY29ubmVjdG9yX2FmdGVyX2RldGVjdCgKPiAgIAo+ICAg c3RydWN0IGFtZGdwdV9kbV9jb25uZWN0b3IgKmFtZGdwdV9kbV9maW5kX2ZpcnN0X2NyY3RfbWF0 Y2hpbmdfY29ubmVjdG9yKAo+ICAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAt CXN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCWJvb2wgZnJvbV9zdGF0ZV92YXIpOwo+ICsJc3Ry dWN0IGRybV9jcnRjICpjcnRjKTsKPiAgIAo+ICAgCj4gICBzdHJ1Y3QgYW1kZ3B1X2ZyYW1lYnVm ZmVyOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==